Re: LMB regression...

2008-04-24 Thread David Miller
From: Paul Mackerras <[EMAIL PROTECTED]> Date: Thu, 24 Apr 2008 16:56:26 +1000 > David Miller writes: > > > Specifically, you removed the aligning of the size argument given to > > lmb_add_region() in the lmb allocators, and that is critical when > > allocating many small chunks, we run out of LM

Re: LMB regression...

2008-04-23 Thread Paul Mackerras
David Miller writes: > Specifically, you removed the aligning of the size argument given to > lmb_add_region() in the lmb allocators, and that is critical when > allocating many small chunks, we run out of LMB slots otherwise > and allocations start failing. Sorry. It's still there in lmb_alloc_

Re: LMB regression...

2008-04-23 Thread David Miller
From: Michael Ellerman <[EMAIL PROTECTED]> Date: Thu, 24 Apr 2008 16:35:33 +1000 > Sounds like we need a test suite :) Maybe :-) Anyways, here is the bug fix I plan to push to Linus with my sparc64 NUMA changes, unless someone has an objection: [LMB]: Fix lmb allocation regression. Changeset d

Re: LMB regression...

2008-04-23 Thread Michael Ellerman
On Wed, 2008-04-23 at 23:24 -0700, David Miller wrote: > Paul, I finally got around to testing your changeset on sparc64, it > breaks things: > > commit d9024df02ffe74d723d97d552f86de3b34beb8cc > Author: Paul Mackerras <[EMAIL PROTECTED]> > Date: Sat Apr 12 15:20:59 2008 +1000 > > [LMB] Res

LMB regression...

2008-04-23 Thread David Miller
Paul, I finally got around to testing your changeset on sparc64, it breaks things: commit d9024df02ffe74d723d97d552f86de3b34beb8cc Author: Paul Mackerras <[EMAIL PROTECTED]> Date: Sat Apr 12 15:20:59 2008 +1000 [LMB] Restructure allocation loops to avoid unsigned underflow ... Specif