Re: Gianfar ethernet device

2007-11-12 Thread Jon Smirl
On 11/11/07, Jon Smirl <[EMAIL PROTECTED]> wrote: > On 11/11/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > > > The real solution is that gianfar support belongs in a device driver, > > > not in a common file. That whole fsl_soc.c file is a catch-all of > > > things that belong in devi

Re: Gianfar ethernet device

2007-11-11 Thread Benjamin Herrenschmidt
On Sun, 2007-11-11 at 20:16 -0500, Jon Smirl wrote: > > Are there powerpc platforms without device trees? Not in arch/powerpc. Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Gianfar ethernet device

2007-11-11 Thread Jon Smirl
On 11/11/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > The real solution is that gianfar support belongs in a device driver, > > not in a common file. That whole fsl_soc.c file is a catch-all of > > things that belong in device drivers. I haven't looked at every line > > in it, but 90

Re: Gianfar ethernet device

2007-11-11 Thread Benjamin Herrenschmidt
> The real solution is that gianfar support belongs in a device driver, > not in a common file. That whole fsl_soc.c file is a catch-all of > things that belong in device drivers. I haven't looked at every line > in it, but 90%+ of the code should be moved into device drivers. > > I'm preparing a

Re: Gianfar ethernet device

2007-11-11 Thread Jon Smirl
BTW, this exercise of disabling platform bus is turning up some real bugs. There are several tests in the kernel like this: if (!shost->shost_gendev.parent) shost->shost_gendev.parent = dev ? dev : &platform_bus; if (adap->dev.parent == NULL) { ada

Re: Gianfar ethernet device

2007-11-11 Thread Jon Smirl
On 11/11/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Sun, 2007-11-11 at 18:30 -0500, Jon Smirl wrote: > > Does this patch add the right ifdefs in fsl_soc.c to make these > > drivers build on their proper platforms? As an experiment I have > > disabled platform bus on the mpc5200 an

Re: Gianfar ethernet device

2007-11-11 Thread Benjamin Herrenschmidt
On Sun, 2007-11-11 at 18:30 -0500, Jon Smirl wrote: > Does this patch add the right ifdefs in fsl_soc.c to make these > drivers build on their proper platforms? As an experiment I have > disabled platform bus on the mpc5200 and I'm only using of_platform > bus. Turning off platform bus is exposing

Re: Gianfar ethernet device

2007-11-11 Thread Jon Smirl
Does this patch add the right ifdefs in fsl_soc.c to make these drivers build on their proper platforms? As an experiment I have disabled platform bus on the mpc5200 and I'm only using of_platform bus. Turning off platform bus is exposing a lot of code that is getting built into my mpc5200 kernel t

Gianfar ethernet device

2007-11-11 Thread Jon Smirl
Which platforms have the Gianfar ethernet device? The gfar code in fsl_soc.c is getting built on the mpc5200 and it doesn't have the device. -- Jon Smirl [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/ma