Re: Fwd: [PATCH v4 12/18] cxl: Add guest-specific code

2016-02-22 Thread Frederic Barrat
Manoj, cxl hasn't been and is not checkpatch-clean. That being said, we tried to not make it worse. I've let go 2 types of reports, which were already present in the cxl code: - lines longer than 80 characters, when it's not showing a clear sign that code should be refactored - assignment in

Re: Fwd: [PATCH v4 12/18] cxl: Add guest-specific code

2016-02-21 Thread Manoj Kumar
Christophe, Fred: Is getting the code checkpatch clean not a requirement for this component? total: 458 errors, 995 warnings, 1602 lines checked NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile I am stopping my review at this point. Will pick