Re: AZFS file system proposal

2008-07-09 Thread Maxim Shchetynin
> I'd rather do > > pgprot_t prot; > > #ifdef CONFIG_PPC > prot = > #else > prot = pgprot_noncached(...) > #endif > vma->vm_page_prot = prot; I have changed my patch accordinly. Thank you. -- Mit freundlichen Grüßen / met vriendelijke groeten / avec regards Maxim

Re: AZFS file system proposal

2008-07-09 Thread Benjamin Herrenschmidt
On Wed, 2008-07-09 at 11:14 +0200, Maxim Shchetynin wrote: > Am Wed, 09 Jul 2008 18:58:38 +1000 > schrieb Benjamin Herrenschmidt <[EMAIL PROTECTED]>: > > > On Tue, 2008-07-01 at 16:59 +0200, Arnd Bergmann wrote: > > > I wouldn't hold up merging the file system for this problem, but > > > until it

Re: AZFS file system proposal

2008-07-09 Thread Maxim Shchetynin
Am Wed, 09 Jul 2008 18:58:38 +1000 schrieb Benjamin Herrenschmidt <[EMAIL PROTECTED]>: > On Tue, 2008-07-01 at 16:59 +0200, Arnd Bergmann wrote: > > I wouldn't hold up merging the file system for this problem, but > > until it is solved, the Kconfig entry should probably have > > a "depends on PPC

Re: AZFS file system proposal

2008-07-09 Thread Benjamin Herrenschmidt
On Tue, 2008-07-01 at 16:59 +0200, Arnd Bergmann wrote: > I wouldn't hold up merging the file system for this problem, but > until it is solved, the Kconfig entry should probably have > a "depends on PPC". Better, use an ifdef for powerpc flags, and #else to pgprot_noncached. Ben. _

Re: AZFS file system proposal

2008-07-08 Thread Benjamin Herrenschmidt
> Cc:'ing some more people that might have more of a clue on this question. > _memcpy_fromio does a "sync" at the start and an "eieio" at the end. > IFAICT, neither are needed here because the source is always memory. > > It also handles unaligned memory accesses, which copy_to_user should > also

Re: AZFS file system proposal

2008-07-08 Thread Arnd Bergmann
On Monday 07 July 2008, Maxim Shchetynin wrote: > > > +   if (copy_to_user(target, (void*) pin, size)) { > > > +   rc = -EFAULT; > > > +   goto out; > > > +   } > > > > Question to the powerpc folks: is copy_to_user safe for an __iomem source? > > Sh

Re: AZFS file system proposal

2008-07-07 Thread Maxim Shchetynin
Thank you Arnd for your comments. I have changed my patch accordinly (I will send it in a few minutes). > > Subject: azfs: initial submit of azfs, a non-buffered filesystem > > Please make the patch subject the actual subject of your email next time, > and put the introductory text below the Sig

Re: AZFS file system proposal

2008-07-01 Thread Arnd Bergmann
On Wednesday 18 June 2008, Maxim Shchetynin wrote: > AZFS patch updated accordinly to comments of Christoph Hellwig and Dmitri > Vorobiev. Sorry for my not commenting earlier on this. I'm finally collecting my 2.6.27 patches and stumbled over it again. There are a few details that I hope we can f