Re: [v2 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-06 Thread David Miller
From: Liang Li Date: Fri, 3 Sep 2010 00:02:44 +0800 > + printk(KERN_INFO "Stopping interface %s.\n", netdev->name); ... > + printk(KERN_INFO "Reactivating interface %s.\n", netdev->name); Please get rid of these log messages. Also, this isn't the way to implement this.

Re: [v2 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Liang Li
On Thu, Sep 02, 2010 at 07:04:59PM +0100, Ben Hutchings wrote: > On Fri, 2010-09-03 at 00:02 +0800, Liang Li wrote: > > It's common sense that when we should do change to driver ring > > desc/buffer etc only after 'stop/shutdown' the device. When we > > do change while devices/driver is running, ke

Re: [v2 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Ben Hutchings
On Fri, 2010-09-03 at 00:02 +0800, Liang Li wrote: > It's common sense that when we should do change to driver ring > desc/buffer etc only after 'stop/shutdown' the device. When we > do change while devices/driver is running, kernel oops occur: [...] > + printk(KERN_INFO "Reactivating i

[v2 PATCH] ucc_geth: fix ethtool set ring param bug

2010-09-02 Thread Liang Li
It's common sense that when we should do change to driver ring desc/buffer etc only after 'stop/shutdown' the device. When we do change while devices/driver is running, kernel oops occur: [ r...@fsl_8569mds:/root> ethtool -G eth0 tx 256 r...@fsl_8569mds:/root> Oops: Kernel access of bad area, sig: