Re: [PATCH v2] powerpc/powernv: Fix race in updating core_idle_state

2015-07-09 Thread Michael Ellerman
On Thu, 2015-07-09 at 14:41 +1000, Daniel Axtens wrote: > > I recommend creating an alias or script that does: > > > > $ git log --pretty=fixes -n 1 $commit | xclip > > > > FWIW, having finally got around to doing this, I found I first needed > the following snippet in ~/.gitconfig from > https:

Re: [PATCH v2] powerpc/powernv: Fix race in updating core_idle_state

2015-07-08 Thread Shreyas B Prabhu
On 07/09/2015 10:11 AM, Daniel Axtens wrote: >> I recommend creating an alias or script that does: >> >> $ git log --pretty=fixes -n 1 $commit | xclip >> > > FWIW, having finally got around to doing this, I found I first needed > the following snippet in ~/.gitconfig from > https://www.kernel.or

Re: [PATCH v2] powerpc/powernv: Fix race in updating core_idle_state

2015-07-08 Thread Daniel Axtens
> I recommend creating an alias or script that does: > > $ git log --pretty=fixes -n 1 $commit | xclip > FWIW, having finally got around to doing this, I found I first needed the following snippet in ~/.gitconfig from https://www.kernel.org/doc/Documentation/SubmittingPatches [core]

Re: [v2] powerpc/powernv: Fix race in updating core_idle_state

2015-07-07 Thread Michael Ellerman
On Mon, 2015-06-07 at 20:09:23 UTC, "Shreyas B. Prabhu" wrote: > core_idle_state is maintained for each core. It uses 0-7 bits to track > whether a thread in the core has entered fastsleep or winkle. 8th bit is > used as a lock bit. ... > Signed-off-by: Shreyas B. Prabhu > Fixes: 7b54e9f213f76 'po

Re: [PATCH v2] powerpc/powernv: Fix race in updating core_idle_state

2015-07-06 Thread Shreyas B Prabhu
On 07/07/2015 05:52 AM, Michael Ellerman wrote: > On Tue, 2015-07-07 at 01:39 +0530, Shreyas B. Prabhu wrote: >> Signed-off-by: Shreyas B. Prabhu >> Fixes: 7b54e9f213f76 'powernv/powerpc: Add winkle support for offline >> cpus' > > The sha is wrong, it should be 77b54e9f213f. > Argh! Sorry > A

Re: [PATCH v2] powerpc/powernv: Fix race in updating core_idle_state

2015-07-06 Thread Michael Ellerman
On Tue, 2015-07-07 at 01:39 +0530, Shreyas B. Prabhu wrote: > core_idle_state is maintained for each core. It uses 0-7 bits to track > whether a thread in the core has entered fastsleep or winkle. 8th bit is > used as a lock bit. ... > This patch fixes the above race by looping on the lock bit even

[PATCH v2] powerpc/powernv: Fix race in updating core_idle_state

2015-07-06 Thread Shreyas B. Prabhu
core_idle_state is maintained for each core. It uses 0-7 bits to track whether a thread in the core has entered fastsleep or winkle. 8th bit is used as a lock bit. The lock bit is set in these 2 scenarios- - The thread is first in subcore to wakeup from sleep/winkle. - If its the last thread in t