Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-11 Thread Brian Norris
Hi, On Thu, Oct 10, 2013 at 12:37 PM, Anatolij Gustschin wrote: > On Thu, 10 Oct 2013 11:23:55 -0700 > Brian Norris wrote: >> > Yes, we also have to remove CONFIG_FB_FSL_DIU ifdef in >> > arch/powerpc/sysdev/fsl_soc.h and building should work then. >> >> Still want it around this line, probably,

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-10 Thread Anatolij Gustschin
Hello, On Thu, 10 Oct 2013 11:23:55 -0700 Brian Norris wrote: ... > > making mpc512x_setup_diu(), mpc512x_release_bootmem(), > > mpc512x_valid_monitor_port() and void mpc512x_set_pixel_clock() > > should be okay. > > And mpc512x_init_diu()? yes, it can be static, too. > > >> Then, you can get

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-10 Thread Brian Norris
Hello, On Thu, Oct 10, 2013 at 9:09 AM, Anatolij Gustschin wrote: > On Wed, 9 Oct 2013 12:29:31 -0700 > Brian Norris wrote: > ... >> > +#else >> > +void __init mpc512x_setup_diu(void) { /* EMPTY */ } >> > +void __init mpc512x_init_diu(void) { /* EMPTY */ } >> > #endif >> > >> > void __init mpc

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-10 Thread Anatolij Gustschin
Hi, On Wed, 9 Oct 2013 12:29:31 -0700 Brian Norris wrote: ... > > +#else > > +void __init mpc512x_setup_diu(void) { /* EMPTY */ } > > +void __init mpc512x_init_diu(void) { /* EMPTY */ } > > #endif > > > > void __init mpc512x_init_IRQ(void) > > I see an alternative solution: > > Can't almost

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-09 Thread Brian Norris
Hi all, (Please keep me on the CC list, as I'm not subscribed) On Fri, Sep 27, 2013 at 05:28:38PM +0200, Gerhard Sittig wrote: > a disabled Kconfig option results in a reference to a not implemented > routine when the IS_ENABLED() macro is used for both conditional > implementation of the routine

Re: [PATCH v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-08 Thread Anatolij Gustschin
On Fri, 27 Sep 2013 17:28:38 +0200 Gerhard Sittig wrote: > a disabled Kconfig option results in a reference to a not implemented > routine when the IS_ENABLED() macro is used for both conditional > implementation of the routine as well as a C language source code test > at the call site -- the "i

[PATCH v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-09-27 Thread Gerhard Sittig
a disabled Kconfig option results in a reference to a not implemented routine when the IS_ENABLED() macro is used for both conditional implementation of the routine as well as a C language source code test at the call site -- the "if (0) func();" construct only gets eliminated later by the optimize