Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-04 Thread Geert Uytterhoeven
On Wed, 4 Mar 2009, Alessandro Zummo wrote: > On Wed, 4 Mar 2009 09:26:29 +0100 (CET) > Geert Uytterhoeven wrote: > > > Thanks Paul, I wasn't aware of that thread! > > > > Yes, this is almost the same. The only part I don't agree with is the move > > of > > the creation of the platform device f

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-04 Thread Alessandro Zummo
On Wed, 4 Mar 2009 09:26:29 +0100 (CET) Geert Uytterhoeven wrote: > Thanks Paul, I wasn't aware of that thread! > > Yes, this is almost the same. The only part I don't agree with is the move of > the creation of the platform device from arch-specific code to rtc-firmware.c, > as this makes autol

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-04 Thread Geert Uytterhoeven
On Wed, 4 Mar 2009, Paul Mundt wrote: > On Tue, Mar 03, 2009 at 11:41:23AM +0100, Geert Uytterhoeven wrote: > > So would you accept a patch series that: > > 1. Adds the missing module aliases to rtc-parisc (which is a bugfix), > > 2. Moves the platform device creation out of rtc-ppc and into >

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-03 Thread Paul Mundt
On Tue, Mar 03, 2009 at 11:41:23AM +0100, Geert Uytterhoeven wrote: > So would you accept a patch series that: > 1. Adds the missing module aliases to rtc-parisc (which is a bugfix), > 2. Moves the platform device creation out of rtc-ppc and into arch-specific > code (which is also a bugfi

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-03 Thread Alessandro Zummo
On Tue, 3 Mar 2009 11:41:23 +0100 (CET) Geert Uytterhoeven wrote: > rtc-generic is already in the kernel, it's just called rtc-parisc ;-) Really? I never saw it :) > > But I'd strongly suggest to plan and execute a conversion process. > > So would you accept a patch series that: > 1. Adds

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-03 Thread Geert Uytterhoeven
On Mon, 2 Mar 2009, Alessandro Zummo wrote: > On Mon, 2 Mar 2009 11:28:01 +0100 (CET) > Geert Uytterhoeven wrote: > > So I can solve my problem (autoloading the RTC driver on PS3 by udev) by > > converting the old genrtc driver into a platform device driver and creating > > platform devices where

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-02 Thread Alessandro Zummo
On Mon, 2 Mar 2009 11:28:01 +0100 (CET) Geert Uytterhoeven wrote: > So I can solve my problem (autoloading the RTC driver on PS3 by udev) by > converting the old genrtc driver into a platform device driver and creating > platform devices where appropriate. yes. btw, if you are building a kernel

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-02 Thread Geert Uytterhoeven
On Mon, 2 Mar 2009, Alessandro Zummo wrote: > On Mon, 2 Mar 2009 10:54:14 +0100 (CET) > Geert Uytterhoeven wrote: > > Indeed. You can have a working RTC class driver for lots of hardware by just > > writing ca. 100 lines of code on top of the generic framework. > > That's true, but we would then

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-02 Thread Alessandro Zummo
On Mon, 2 Mar 2009 10:54:14 +0100 (CET) Geert Uytterhoeven wrote: > Indeed. You can have a working RTC class driver for lots of hardware by just > writing ca. 100 lines of code on top of the generic framework. That's true, but we would then have two generic frameworks. And one of them will hav

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-03-02 Thread Geert Uytterhoeven
On Fri, 27 Feb 2009, Richard Zidlicky wrote: > On Wed, Feb 25, 2009 at 11:18:36AM +0100, Alessandro Zummo wrote: > > On Wed, 25 Feb 2009 11:00:13 +0100 (CET) > > Geert Uytterhoeven wrote: > > > > > I didn't know NTP was broken with RTC class drivers? > > > > > > So we should actually keep on usi

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-27 Thread Richard Zidlicky
On Wed, Feb 25, 2009 at 11:18:36AM +0100, Alessandro Zummo wrote: > On Wed, 25 Feb 2009 11:00:13 +0100 (CET) > Geert Uytterhoeven wrote: > > > I didn't know NTP was broken with RTC class drivers? > > > > So we should actually keep on using genrtc instead of rtc-ppc/rtc-generic > > for > > now?

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-27 Thread Maciej W. Rozycki
On Wed, 25 Feb 2009, Alessandro Zummo wrote: > > I didn't know NTP was broken with RTC class drivers? > > > > So we should actually keep on using genrtc instead of rtc-ppc/rtc-generic > > for > > now? ;-) > > broken here means that the kernel won't save the time to the hardware > rtc every 11

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-27 Thread Alessandro Zummo
On Fri, 27 Feb 2009 17:17:36 + (GMT) "Maciej W. Rozycki" wrote: > I posted patches to support it last year -- from your answer I infer they > were not applied in the end. I'll see if I can try to refresh them and > push again next time I'll be upgrading my kernel. they were almost ok bu

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-25 Thread Alessandro Zummo
On Wed, 25 Feb 2009 11:00:13 +0100 (CET) Geert Uytterhoeven wrote: > I didn't know NTP was broken with RTC class drivers? > > So we should actually keep on using genrtc instead of rtc-ppc/rtc-generic for > now? ;-) broken here means that the kernel won't save the time to the hardware rtc ever

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-25 Thread Geert Uytterhoeven
On Tue, 24 Feb 2009, Brad Boyer wrote: > On Tue, Feb 24, 2009 at 07:37:08PM +0100, Alessandro Zummo wrote: > > On Tue, 24 Feb 2009 18:56:03 +0100 (CET) > > Geert Uytterhoeven wrote: > > > Converting all (ca. 20?) ppc and m68k RTC support code into individual RTC > > > class drivers would add ca. 1

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-24 Thread Brad Boyer
On Tue, Feb 24, 2009 at 07:37:08PM +0100, Alessandro Zummo wrote: > On Tue, 24 Feb 2009 18:56:03 +0100 (CET) > Geert Uytterhoeven wrote: > > Converting all (ca. 20?) ppc and m68k RTC support code into individual RTC > > class drivers would add ca. 100+ lines of code for each individual driver. >

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-24 Thread Alessandro Zummo
On Tue, 24 Feb 2009 18:56:03 +0100 (CET) Geert Uytterhoeven wrote: > > On Mon, 23 > > > > I'd start writing a working driver and then see how we should eventually > > adapt the rtc subsystem to cope with your needs. > > OK, so here's a first example: rtc-ps3. > > Note that this single patch

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-24 Thread Geert Uytterhoeven
On Mon, 23 Feb 2009, Alessandro Zummo wrote: > On Mon, 23 Feb 2009 13:34:49 +0100 (CET) > Geert Uytterhoeven wrote: > > >my opinion on this kind of stuff is that I want to avoid the layering > > > of implementations under the rtc subsystem. I'd rather prefer that each > > > rtc device had it

Re: [rtc-linux] Re: [PATCH/RFC 0/5] Generic RTC class driver

2009-02-23 Thread Alessandro Zummo
On Mon, 23 Feb 2009 13:34:49 +0100 (CET) Geert Uytterhoeven wrote: > > Hello, > > > >my opinion on this kind of stuff is that I want to avoid the layering > > of implementations under the rtc subsystem. I'd rather prefer that each > > rtc device had its own driver. > > > > I've made