Re: [patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()

2008-03-03 Thread Jesse Barnes
On Thursday, February 28, 2008 9:31 am Grant Grundler wrote: > In general, I'm wondering if the check for device class would be > sufficient here to NOT enable PERR/SERR for graphics automatically. > While disabling PERR was "the right thing" for older "mostly write" > devices of the 1990's and ear

Re: [patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()

2008-02-28 Thread Kyle McMartin
On Wed, Feb 27, 2008 at 05:04:42PM -0700, Bjorn Helgaas wrote: > Move PERR and SERR enables from pcibios_enable_resources() to > platform_pci_enable_device() so the former matches other > architectures and can be shared. > I don't have any problems with this, but I think the naming needs to chang

Re: [patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()

2008-02-28 Thread Grant Grundler
On Wed, Feb 27, 2008 at 05:04:42PM -0700, Bjorn Helgaas wrote: > Move PERR and SERR enables from pcibios_enable_resources() to > platform_pci_enable_device() so the former matches other > architectures and can be shared. > > Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> Ack-By: Grant Grundler

[patch 5/6] PARISC: move PERR & SERR enables out of pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
Move PERR and SERR enables from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared. Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> Index: work6/arch/parisc/kernel/pci.c ==