Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-27 Thread David Gibson
On Tue, Sep 25, 2007 at 10:33:58PM +0200, Segher Boessenkool wrote: > >>> Hrm... we probably want an "i2c" device_type class, but I don't think > >>> we've actually defined one, which is a problem > >> > >> By defining new device_type's, or new semantics for device_type, > >> you open the door to (

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-25 Thread Segher Boessenkool
>>> Hrm... we probably want an "i2c" device_type class, but I don't think >>> we've actually defined one, which is a problem >> >> By defining new device_type's, or new semantics for device_type, >> you open the door to (accidentally) becoming incompatible with >> "real" OF. > > Hrm... perhaps. Bu

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-24 Thread David Gibson
On Tue, Sep 25, 2007 at 07:33:15AM +0200, Peter Korsgaard wrote: > > "David" == David Gibson <[EMAIL PROTECTED]> writes: > > Hi, > > >> The Linux driver for the chip (rtc-1307.c) doesn't expose the NVRAM > >> bytes either. > > David> Incidentally how are you planning on instantiating the

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-24 Thread Peter Korsgaard
> "David" == David Gibson <[EMAIL PROTECTED]> writes: Hi, >> The Linux driver for the chip (rtc-1307.c) doesn't expose the NVRAM >> bytes either. David> Incidentally how are you planning on instantiating the driver? AFAIK David> all the rtc-* drivers are platform drivers rather than of_

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-24 Thread David Gibson
On Mon, Sep 24, 2007 at 07:52:22AM +0200, Peter Korsgaard wrote: > > "David" == David Gibson <[EMAIL PROTECTED]> writes: > > Hi > > >> compatible = "fsl-i2c"; > >> reg = <3100 100>; > >> interrupts = ; > >> interrupt-parent = < &ipic >; > >> dfsrr; > >> + > >> + [EMAIL

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-24 Thread David Gibson
On Mon, Sep 24, 2007 at 11:11:28PM +0200, Segher Boessenkool wrote: > >> Scott> #size-cells is zero on i2c, so it should just be reg = <68>. > >> > >> Scott> You'll probably need to add #address-cells and #size-cells to > >> the > >> Scott> controller node, as well. > > > > Uh.. yes.. i2c inter

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-24 Thread David Gibson
On Mon, Sep 24, 2007 at 09:52:31AM -0500, Scott Wood wrote: > David Gibson wrote: > >>[EMAIL PROTECTED] { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >>device_type = "i2c"; > > > > Hrm... we probably want an "i2c" devic

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-24 Thread Segher Boessenkool
>> Scott> #size-cells is zero on i2c, so it should just be reg = <68>. >> >> Scott> You'll probably need to add #address-cells and #size-cells to >> the >> Scott> controller node, as well. > > Uh.. yes.. i2c interfaces should really always have #a and #s. More generally, every node that define

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-24 Thread Scott Wood
David Gibson wrote: >> [EMAIL PROTECTED] { >> +#address-cells = <1>; >> +#size-cells = <0>; >> device_type = "i2c"; > > Hrm... we probably want an "i2c" device_type class, but I don't think > we've actually defined one, whic

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-23 Thread Kumar Gala
On Sep 24, 2007, at 12:07 AM, David Gibson wrote: > On Fri, Sep 21, 2007 at 09:35:03AM +0200, Peter Korsgaard wrote: >>> "Scott" == Scott Wood <[EMAIL PROTECTED]> writes: >> >> Hi, >> >> Scott> #size-cells is zero on i2c, so it should just be reg = <68>. >> >> Scott> You'll probably need to

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-23 Thread Peter Korsgaard
> "David" == David Gibson <[EMAIL PROTECTED]> writes: Hi >> compatible = "fsl-i2c"; >> reg = <3100 100>; >> interrupts = ; >> interrupt-parent = < &ipic >; >> dfsrr; >> + >> + [EMAIL PROTECTED] { >> + device_type = "rtc"; >> +

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-23 Thread David Gibson
On Fri, Sep 21, 2007 at 09:35:03AM +0200, Peter Korsgaard wrote: > > "Scott" == Scott Wood <[EMAIL PROTECTED]> writes: > > Hi, > > Scott> #size-cells is zero on i2c, so it should just be reg = <68>. > > Scott> You'll probably need to add #address-cells and #size-cells to the > Scott> cont

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-21 Thread Peter Korsgaard
> "Scott" == Scott Wood <[EMAIL PROTECTED]> writes: Hi, Scott> #size-cells is zero on i2c, so it should just be reg = <68>. Scott> You'll probably need to add #address-cells and #size-cells to the Scott> controller node, as well. Ahh - Thanks. This should be better. --- [PATCH] mpc8349e

Re: [patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-20 Thread Scott Wood
On Thu, Sep 20, 2007 at 12:42:14PM +0200, Peter Korsgaard wrote: > Index: linux/arch/powerpc/boot/dts/mpc8349emitx.dts > === > --- linux.orig/arch/powerpc/boot/dts/mpc8349emitx.dts > +++ linux/arch/powerpc/boot/dts/mpc8349emitx.dts > @

[patch 3/3] mpc8349emitx.dts: Add ds1339 RTC

2007-09-20 Thread Peter Korsgaard
Add ds1339 I2C RTC chip as child of 2nd I2C controller. Cc: Timur Tabi <[EMAIL PROTECTED]> Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8349emitx.dts |7 +++ 1 file changed, 7 insertions(+) Index: linux/arch/powerpc/boot/dts/mpc8349emitx.dts ===