Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-19 Thread Rene Herman
On 07/19/2007 11:47 AM, Andrew Morton wrote: > On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <[EMAIL > PROTECTED]> wrote: > >>> Oh dear. >>> >>> ps3rom_priv(dev) = host; >>> >>> that's 'orrid. We have an identifier pretending to be a function, only we >>> go and treat it as a

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > Oh dear. > > > > ps3rom_priv(dev) = host; > > > > that's 'orrid. We have an identifier pretending to be a function, only we > > go and treat it as an lvalue. > > > > I mean, C code should look like

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-19 Thread Jens Axboe
On Thu, Jul 19 2007, Geert Uytterhoeven wrote: > On Thu, 19 Jul 2007, Andrew Morton wrote: > > On Thu, 19 Jul 2007 11:02:07 +0200 (CEST) Geert Uytterhoeven <[EMAIL > > PROTECTED]> wrote: > > > > > On Wed, 18 Jul 2007, Andrew Morton wrote: > > > > > +struct ps3rom_private { > > > > > + struct

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-19 Thread Geert Uytterhoeven
On Thu, 19 Jul 2007, Andrew Morton wrote: > On Thu, 19 Jul 2007 11:02:07 +0200 (CEST) Geert Uytterhoeven <[EMAIL > PROTECTED]> wrote: > > > On Wed, 18 Jul 2007, Andrew Morton wrote: > > > > +struct ps3rom_private { > > > > + struct ps3_storage_device *dev; > > > > + struct scsi_cmnd *

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 11:02:07 +0200 (CEST) Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > On Wed, 18 Jul 2007, Andrew Morton wrote: > > > +struct ps3rom_private { > > > + struct ps3_storage_device *dev; > > > + struct scsi_cmnd *curr_cmd; > > > +}; > > > +#define ps3rom_priv(dev) ((dev)->sbd.core

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-19 Thread Geert Uytterhoeven
On Wed, 18 Jul 2007, Andrew Morton wrote: > > +struct ps3rom_private { > > + struct ps3_storage_device *dev; > > + struct scsi_cmnd *curr_cmd; > > +}; > > +#define ps3rom_priv(dev) ((dev)->sbd.core.driver_data) > > + > > Someone should invent a keyboard which delivers an electric shock when

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-18 Thread Andrew Morton
On Mon, 16 Jul 2007 18:15:41 +0200 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > From: Geert Uytterhoeven <[EMAIL PROTECTED]> > > Add a BD/DVD/CD-ROM Storage Driver for the PS3: > - Implemented as a SCSI device driver > - Uses software scatter-gather with a 64 KiB bounce buffer as the hyper

[patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-16 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> Add a BD/DVD/CD-ROM Storage Driver for the PS3: - Implemented as a SCSI device driver - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor doesn't support scatter-gather CC: Geoff Levand <[EMAIL PROTECTED]> Signed-off-by