Re: [patch 04/10] 4xx bootwrapper reworks

2007-08-07 Thread David Gibson
On Tue, Aug 07, 2007 at 08:10:38AM -0500, Josh Boyer wrote: > On Tue, 7 Aug 2007 13:05:47 +1000 > David Gibson <[EMAIL PROTECTED]> wrote: > > > > > Rather than just removing these defines and using hardcoded values, > > > > I'd prefer to see separate SPRN_DBCR0_40X and SPRN_DBCR0_44X defines. > >

Re: [patch 04/10] 4xx bootwrapper reworks

2007-08-07 Thread Josh Boyer
On Tue, 7 Aug 2007 13:05:47 +1000 David Gibson <[EMAIL PROTECTED]> wrote: > > > Rather than just removing these defines and using hardcoded values, > > > I'd prefer to see separate SPRN_DBCR0_40X and SPRN_DBCR0_44X defines. > > > > Ok. And place them where? In the same file since they aren't DC

Re: [patch 04/10] 4xx bootwrapper reworks

2007-08-06 Thread David Gibson
On Mon, Aug 06, 2007 at 07:36:03AM -0500, Josh Boyer wrote: > On Mon, Aug 06, 2007 at 02:38:55PM +1000, David Gibson wrote: > > On Fri, Aug 03, 2007 at 11:09:04AM -0500, Josh Boyer wrote: > > > -#define SPRN_DBCR0 0x134 > > > -#define DBCR0_RST_SYSTEM 0x3000 > > > +#define

Re: [patch 04/10] 4xx bootwrapper reworks

2007-08-06 Thread Josh Boyer
On Mon, Aug 06, 2007 at 02:38:55PM +1000, David Gibson wrote: > On Fri, Aug 03, 2007 at 11:09:04AM -0500, Josh Boyer wrote: > > -#define SPRN_DBCR0 0x134 > > -#define DBCR0_RST_SYSTEM 0x3000 > > +#define DBCR0_RST_SYSTEM 0x3000 > > Rather than just removing these defines and usin

Re: [patch 04/10] 4xx bootwrapper reworks

2007-08-05 Thread David Gibson
On Fri, Aug 03, 2007 at 11:09:04AM -0500, Josh Boyer wrote: > Make the fixup_memsize function common for all of 4xx as several chips share > the same SDRAM controller. Also add functions to reset 40x chips and quiesce > the ethernet. > > Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> > > --- > a

[patch 04/10] 4xx bootwrapper reworks

2007-08-03 Thread Josh Boyer
Make the fixup_memsize function common for all of 4xx as several chips share the same SDRAM controller. Also add functions to reset 40x chips and quiesce the ethernet. Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> --- arch/powerpc/boot/44x.h |4 arch/powerpc/boot/4xx.c | 36 +