Hi Andre, Guenter, Jeff,
On Wed, 21 Jul 2010 21:46:50 +0200, Andre Prendel wrote:
> On Tue, Jul 20, 2010 at 08:59:52AM -0700, Guenter Roeck wrote:
> > On Tue, Jul 20, 2010 at 11:09:53AM -0400, Andre Prendel wrote:
> > > On Thu, May 20, 2010 at 09:35:56PM +0200, Andre Prendel wrote:
> > > > On Thu,
On Tue, Jul 20, 2010 at 08:59:52AM -0700, Guenter Roeck wrote:
> On Tue, Jul 20, 2010 at 11:09:53AM -0400, Andre Prendel wrote:
> > On Thu, May 20, 2010 at 09:35:56PM +0200, Andre Prendel wrote:
> > > On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote:
> > > > In any event, here it is a
On Thu, May 20, 2010 at 09:35:56PM +0200, Andre Prendel wrote:
> On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote:
> > In any event, here it is again:
>
> Acked-by: Andre Prendel
Hi Jeff,
I'de suggest to resend the patch with my acked-by to the lm-sensors list and
Andrew Morton. I
On Thu, May 20, 2010 at 09:35:56PM +0200, Andre Prendel wrote:
> On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote:
> > On 05/20/2010 02:50 PM, Andre Prendel wrote:
> > > You made a careless mistake, see below. Please fix this and resend the
> > > patch
> > > again. Then I added my Ac
On Thu, May 20, 2010 at 03:07:05PM -0400, Jeff Angielski wrote:
> On 05/20/2010 02:50 PM, Andre Prendel wrote:
> > You made a careless mistake, see below. Please fix this and resend the patch
> > again. Then I added my Acked-by and I think Jean will schedule the patch for
> > 2.6.35 (after another
On 05/20/2010 02:50 PM, Andre Prendel wrote:
> You made a careless mistake, see below. Please fix this and resend the patch
> again. Then I added my Acked-by and I think Jean will schedule the patch for
> 2.6.35 (after another review of course :))
You sir, would be correct... *sigh* I tried usin
On Wed, May 19, 2010 at 01:13:04PM -0400, Jeff Angielski wrote:
> On 05/19/2010 03:26 AM, Andre Prendel wrote:
> > Ok, so there is only one remaining task :) Please update the documentation
> > under
> > Documentation/hwmon/tmp421. Then you will get my Acked-by.
>
> Documentation is updated in th
On 05/19/2010 03:26 AM, Andre Prendel wrote:
> Ok, so there is only one remaining task :) Please update the documentation
> under
> Documentation/hwmon/tmp421. Then you will get my Acked-by.
Documentation is updated in this patch along with the source file.
There is a small cosmetic change in th
Hi Andre,
On Wed, 19 May 2010 09:26:59 +0200, Andre Prendel wrote:
> Jean, should we describe this interface in Documentation/hwmon/sysfs-interface
> too? For the moment tmp421 is the only driver implementing it.
If the values are expressed in a standard unit (i.e. not raw register
values) then y
On Tue, May 18, 2010 at 10:35:21AM -0400, Jeff Angielski wrote:
> On 05/18/2010 07:38 AM, Andre Prendel wrote:
>
> > I'd prefer starting i with 0 and as condition i < data->channels - 1.
> >
> > for (i = 0; i < data->channels -1; i++) {
> > data->nfactor[i] = i2c_smbus_read_byte_data(client,
On 05/18/2010 07:38 AM, Andre Prendel wrote:
> I'd prefer starting i with 0 and as condition i < data->channels - 1.
>
> for (i = 0; i < data->channels -1; i++) {
> data->nfactor[i] = i2c_smbus_read_byte_data(client,
> TMP421_NFACTOR[i]);
> }
>
> What do you think?
The first
On Mon, May 17, 2010 at 04:30:24PM -0400, Jeff Angielski wrote:
>
> Here is a second attempt at a patch to add nfactor support to the tmp421
> driver.
Hi Jeff,
only a few minor issues, see below.
> This includes the changes as suggested by Andre Prendel, the original driver
> author.
>
>
>
12 matches
Mail list logo
