Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-07 Thread Josh Boyer
On Tue, 8 Apr 2008 04:21:44 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Friday 04 April 2008, Jerone Young wrote: > > > > +int __init ppc44x_idle_init(void) > > > > +{ > > > > +   void *func = modes[current_mode].entry; > > > > +   struct device_node *node; > > > > + > > > > +   node = of_

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-07 Thread Arnd Bergmann
On Friday 04 April 2008, Jerone Young wrote: > > > +int __init ppc44x_idle_init(void) > > > +{ > > > +   void *func = modes[current_mode].entry; > > > +   struct device_node *node; > > > + > > > +   node = of_find_node_by_path("/hypervisor"); > > > +   if (node) { > > > +   /* if we find /h

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Segher Boessenkool
+ msr_save = mfmsr(); + /* set wait state MSR */ + mtmsr(msr_save|MSR_WE|MSR_EE|MSR_CE); Did we decide to drop MSR_DE? + /* return to initial state */ + mtmsr(msr_save); It may be my paranoia but I'm pretty sure you need the isync() after _both_ mtmsr()s Certain

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Hollis Blanchard
On Friday 04 April 2008 10:42:41 Jerone Young wrote: > > > +{ > > > +   unsigned long msr_save; > > > + > > > +   msr_save = mfmsr(); > > > +   /* set wait state MSR */ > > > +   mtmsr(msr_save|MSR_WE|MSR_EE|MSR_CE); > > > > Did we decide to drop MSR_DE? > > Hollis argued it down on an earlier emai

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Jerone Young
On Fri, 2008-04-04 at 08:36 -0400, Jimi Xenidis wrote: > On Apr 4, 2008, at 3:06 AM, Jerone Young wrote: > > > # HG changeset patch > > # User Jerone Young <[EMAIL PROTECTED]> > > # Date 1207292108 18000 > > # Node ID afed3e5de82ab6c0ac8d6ceeb0292b6c41ece1ed > > # Parent a5b2aebbc6ebd2439c655f1c0

Re: [kvm-ppc-devel] [PATCH] [v2] Add idle wait support for 44x platforms

2008-04-04 Thread Jimi Xenidis
On Apr 4, 2008, at 3:06 AM, Jerone Young wrote: # HG changeset patch # User Jerone Young <[EMAIL PROTECTED]> # Date 1207292108 18000 # Node ID afed3e5de82ab6c0ac8d6ceeb0292b6c41ece1ed # Parent a5b2aebbc6ebd2439c655f1c047ed7e3c1991ec1 [v2] Add idle wait support for 44x platforms This patch add