Re: [git pull] vfs.git part 1

2017-07-07 Thread Michael Ellerman
Linus Torvalds writes: > On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds > wrote: >> >>> Patch coming. >> >> I'm not seeing a patch, so I did my own. But it's _entirely_ untested. >> Does the attached fix things for you? > > Oh, I see you sent a patch to the list but didn't cc me like in this thr

Re: [git pull] vfs.git part 1

2017-07-07 Thread Michael Ellerman
Linus Torvalds writes: > On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds > wrote: >> >> The copy_flock_fields() macro has the arguments in order , >> but all the users seem to do it the other way around. > > Looking more at it, I think I'd also like copy_flock_fields() to take > pointer arguments

Re: [git pull] vfs.git part 1

2017-07-07 Thread Al Viro
On Fri, Jul 07, 2017 at 10:35:41AM -0700, Linus Torvalds wrote: > Comments? Michael, does this work for your case? Looks sane... > +++ b/fs/fcntl.c > @@ -520,50 +520,50 @@ SYSCALL_DEFINE3(fcntl64, unsigned int, fd, unsigned > int, cmd, > > #ifdef CONFIG_COMPAT > /* careful - don't use anywh

Re: [git pull] vfs.git part 1

2017-07-07 Thread Linus Torvalds
On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds wrote: > > The copy_flock_fields() macro has the arguments in order , > but all the users seem to do it the other way around. Looking more at it, I think I'd also like copy_flock_fields() to take pointer arguments, to match all the code around it (bo

Re: [git pull] vfs.git part 1

2017-07-07 Thread Linus Torvalds
On Fri, Jul 7, 2017 at 8:59 AM, Linus Torvalds wrote: > >> Patch coming. > > I'm not seeing a patch, so I did my own. But it's _entirely_ untested. > Does the attached fix things for you? Oh, I see you sent a patch to the list but didn't cc me like in this thread. Hmm. Al - I'd like to add the "

Re: [git pull] vfs.git part 1

2017-07-07 Thread Linus Torvalds
On Fri, Jul 7, 2017 at 5:46 AM, Michael Ellerman wrote: > Al Viro writes: > >> >> Switch flock copyin/copyout primitives to copy_{from,to}_user() >> (2017-06-26 23:52:44 -0400) > > This commit seems to have broken networking on a bunch of my PPC > machines (64-bit kernel, 32-bit userspace). B

Re: [git pull] vfs.git part 1

2017-07-07 Thread Michael Ellerman
Al Viro writes: > vfs.git topology is rather convoluted this cycle, so > I'm afraid that it'll take more pull requests than usual ;-/ > > The first pile is #work.misc-set_fs. Assorted getting rid > of cargo-culted access_ok(), cargo-culted set_fs() and > field-by-field copyouts. The same