Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Stephen Warren
On 08/15/2013 03:24 AM, Shawn Guo wrote: > On Thu, Aug 15, 2013 at 10:18:23AM +0800, Nicolin Chen wrote: >> Hi Stephen, >> >> On Wed, Aug 14, 2013 at 09:47:19AM -0600, Stephen Warren wrote: >>> If the clock source name list is different, then it needs a different >>> compatible value, so that each

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-15 Thread Shawn Guo
On Thu, Aug 15, 2013 at 10:18:23AM +0800, Nicolin Chen wrote: > Hi Stephen, > > On Wed, Aug 14, 2013 at 09:47:19AM -0600, Stephen Warren wrote: > > If the clock source name list is different, then it needs a different > > compatible value, so that each compatible value can specify which clock > >

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
Hi Stephen, On Wed, Aug 14, 2013 at 09:47:19AM -0600, Stephen Warren wrote: > If the clock source name list is different, then it needs a different > compatible value, so that each compatible value can specify which clock > names are required. > > Also, the compatible value itself should always i

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Stephen Warren
On 08/14/2013 02:14 AM, Shawn Guo wrote: > On Wed, Aug 14, 2013 at 02:34:45PM +0800, Nicolin Chen wrote: >> On Wed, Aug 14, 2013 at 02:39:33PM +0800, Shawn Guo wrote: >>> We only need to maintain those versions that require different >>> programming model in the list. For example, if S/PDIF on Vyb

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Shawn Guo
On Wed, Aug 14, 2013 at 02:34:45PM +0800, Nicolin Chen wrote: > On Wed, Aug 14, 2013 at 02:39:33PM +0800, Shawn Guo wrote: > > We only need to maintain those versions that require different > > programming model in the list. For example, if S/PDIF on Vybrid > > is completely compatible with imx6q

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Nicolin Chen
On Wed, Aug 14, 2013 at 02:39:33PM +0800, Shawn Guo wrote: > We only need to maintain those versions that require different > programming model in the list. For example, if S/PDIF on Vybrid > is completely compatible with imx6q one and uses the exactly same > programming model, we do not need to m

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Shawn Guo
On Wed, Aug 14, 2013 at 01:30:17PM +0800, Nicolin Chen wrote: > Hi Shwan, > > On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote: > > I do not think we need this general compatible string. Device tree > > compatible should be specific. > > So I should just use 'fsl,-spdif" and list all -s

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Nicolin Chen
Hi Shwan, On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote: > I do not think we need this general compatible string. Device tree > compatible should be specific. So I should just use 'fsl,-spdif" and list all -spdif in compatible list? I added 'fsl,fsl-spdif' just for those not-in-list

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Shawn Guo
On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > > +Required properties: > > + > > + - compatible : Compatible list, contains "fsl,-spdif". Using > > general > > Can't we just use "fsl,fsl-spdif" instead? > > > + "fsl,fsl-

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Nicolin Chen
Hi Fabio, Thank you for the comments. On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > > +Required properties: > > + > > + - compatible : Compatible list, contains "fsl,-spdif". Using > > general > > Can't we just use "

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Mark Brown
On Tue, Aug 13, 2013 at 02:58:26PM -0300, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > > +Required properties: > > + - compatible : Compatible list, contains "fsl,-spdif". Using > > general > Can't we just use "fsl,fsl-spdif" instead? It's better to list the s

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Fabio Estevam
On Tue, Aug 13, 2013 at 2:58 PM, Fabio Estevam wrote: > On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: >> +Required properties: >> + >> + - compatible : Compatible list, contains "fsl,-spdif". Using general > > Can't we just use "fsl,fsl-spdif" instead? Or maybe "fsl,imx35-spdif", since m

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Fabio Estevam
On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen wrote: > +Required properties: > + > + - compatible : Compatible list, contains "fsl,-spdif". Using general Can't we just use "fsl,fsl-spdif" instead? > + "fsl,fsl-spdif" will get the default SoC type -- imx6q-spdif. > + I think this is not the us