Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-18 Thread Grant Likely
On Fri, Jul 18, 2008 at 10:58:25AM +0100, Mark Brown wrote: > Sparse (or sparsely used) register maps are pretty common - in practice > it's not been a problem to just have a cache that covers everything and > only gets read, the amount of data involved is rarely that large in the > context of what

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-18 Thread Mark Brown
On Thu, Jul 17, 2008 at 05:31:53PM -0600, Grant Likely wrote: > On Sat, Jul 12, 2008 at 06:36:10PM +0100, Mark Brown wrote: > > /sys/bus/platform/devices/soc-audio/codec_reg > Yikes. The AIC26 has registers all over the place and most of them are > empty. The codec_reg attribute handling means

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-17 Thread Grant Likely
On Sat, Jul 12, 2008 at 06:36:10PM +0100, Mark Brown wrote: > On Sat, Jul 12, 2008 at 12:00:18AM -0600, Grant Likely wrote: > It wouldn't be the only driver not to implement PLL configuration in > this way so that's probably be OK for an initial merge. What's expected > for PLL configuration is t

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-12 Thread Grant Likely
On Sat, Jul 12, 2008 at 11:36 AM, Mark Brown <[EMAIL PROTECTED]> wrote: > The power configuration should be fixed, though. Normally drivers > either fully implement DAPM (including set_bias_level()) or power > everything in the codec up when the driver is loaded. At the minute > what the driver i

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-12 Thread Mark Brown
On Sat, Jul 12, 2008 at 12:00:18AM -0600, Grant Likely wrote: > On Wed, Jul 02, 2008 at 11:48:33AM +0100, Liam Girdwood wrote: > > PLL/FLL/clock config is usually done in a separate function > > (codec_set_pll(), callable by machine driver) so that we can change > > clocks depending on the availab

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-11 Thread Grant Likely
On Wed, Jul 02, 2008 at 11:48:33AM +0100, Liam Girdwood wrote: > On Tue, 2008-07-01 at 17:53 -0600, Grant Likely wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > ASoC Codec driver for the TLV320AIC26 device. This driver uses the ASoC > > v1 API, so I don't expect it to get merged as-is,

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-04 Thread Grant Likely
On Fri, Jul 4, 2008 at 2:49 PM, Mark Brown <[EMAIL PROTECTED]> wrote: > On Tue, Jul 01, 2008 at 05:53:40PM -0600, Grant Likely wrote: >> + /* Tell the of_soc helper about this codec */ >> + of_snd_soc_register_codec(&aic26_soc_codec_dev, aic26, &aic26_dai, >> +

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-04 Thread Mark Brown
On Tue, Jul 01, 2008 at 05:53:40PM -0600, Grant Likely wrote: > +static ssize_t aic26_keyclick_show(struct device *dev, > +struct device_attribute *attr, char *buf) > +{ > + struct aic26 *aic26 = dev_get_drvdata(dev); > + int val, amp, freq, len; > + > +

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-02 Thread Liam Girdwood
On Wed, 2008-07-02 at 09:52 -0400, Jon Smirl wrote: > > I've been using asoc-v2 so it may not be possible to make this arch > independent in asoc-v1. Maybe try porting this to asoc-v2 and see if > a bunch of the registration complexity disappears. Most of soc-of.c > should be unnecessary. > > Li

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-02 Thread Jon Smirl
On 7/1/08, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > ASoC Codec driver for the TLV320AIC26 device. This driver uses the ASoC > v1 API, so I don't expect it to get merged as-is, but I want to get it > out there for review. > --- > > sound/soc/codecs/

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-02 Thread Liam Girdwood
On Tue, 2008-07-01 at 17:53 -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > ASoC Codec driver for the TLV320AIC26 device. This driver uses the ASoC > v1 API, so I don't expect it to get merged as-is, but I want to get it > out there for review. > --- > > sound/soc/codecs