Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-11 Thread Grant Likely
On Mon, Jul 07, 2008 at 12:32:29PM -0400, Jon Smirl wrote: > On 7/1/08, Grant Likely <[EMAIL PROTECTED]> wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > This is an I2S bus driver for the MPC5200 PSC device. It is probably > > will not be merged as-is because it uses v1 of the ASoC API,

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-11 Thread Grant Likely
On Mon, Jul 07, 2008 at 09:23:24AM -0400, Jon Smirl wrote: > On 7/7/08, Mark Brown <[EMAIL PROTECTED]> wrote: > > On Sun, Jul 06, 2008 at 01:56:48PM -0400, Jon Smirl wrote: > > > > > The driver is assuming a capture stream exists. My codec is output only. > > > > > > While the driver declares a ca

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-07 Thread Jon Smirl
On 7/1/08, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This is an I2S bus driver for the MPC5200 PSC device. It is probably > will not be merged as-is because it uses v1 of the ASoC API, but I want > to get it out there for comments. > --- I need some

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-07 Thread Jon Smirl
On 7/7/08, Mark Brown <[EMAIL PROTECTED]> wrote: > On Sun, Jul 06, 2008 at 01:56:48PM -0400, Jon Smirl wrote: > > > The driver is assuming a capture stream exists. My codec is output only. > > > While the driver declares a capture stream the core doesn't require that > both capture and playback b

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-07 Thread Mark Brown
On Sun, Jul 06, 2008 at 01:56:48PM -0400, Jon Smirl wrote: > The driver is assuming a capture stream exists. My codec is output only. While the driver declares a capture stream the core doesn't require that both capture and playback be available - it will cope with a capture only or a playback on

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-06 Thread Jon Smirl
On 7/1/08, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This is an I2S bus driver for the MPC5200 PSC device. It is probably > will not be merged as-is because it uses v1 of the ASoC API, but I want > to get it out there for comments. > --- The driver i

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-04 Thread David Gibson
On Fri, Jul 04, 2008 at 07:03:25AM -0400, Timur Tabi wrote: >> [EMAIL PROTECTED] { // PSC2 >> compatible = "fsl,mpc5200b-psc-i2s","fsl,mpc5200-psc-i2s"; >> cell-index = <1>; > > cell-index should be zero-based, not one-based. Well...since cell-index is fo

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-04 Thread Grant Likely
On Fri, Jul 04, 2008 at 07:03:25AM -0400, Timur Tabi wrote: >> [EMAIL PROTECTED] { // PSC2 >> compatible = "fsl,mpc5200b-psc-i2s","fsl,mpc5200-psc-i2s"; >> cell-index = <1>; > > cell-index should be zero-based, not one-based. > Umm... this is for PSC #2..

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-04 Thread Timur Tabi
[EMAIL PROTECTED] { // PSC2 compatible = "fsl,mpc5200b-psc-i2s","fsl,mpc5200-psc-i2s"; cell-index = <1>; cell-index should be zero-based, not one-based. ___ Linuxppc-dev mailing list Linuxppc-dev@ozl

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-03 Thread Grant Likely
On Wed, Jul 02, 2008 at 11:19:18AM -0400, Jon Smirl wrote: > On 7/1/08, Grant Likely <[EMAIL PROTECTED]> wrote: > > + /* Due to errata in the i2s mode; need to line up enabling > > +* the transmitter with a transition on the frame sync > > +* line */

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-03 Thread Grant Likely
On Wed, Jul 02, 2008 at 09:51:59AM -0400, Jon Smirl wrote: > DMA, needs to be split out. Efika is AC97 on the MPC5200 and needs to > share DMA code. The new Phytec pcm030 baseboard is AC97 too. I agree, but I'm not sure the best way to organize a split. I'm not doing anything with the Efika at th

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-02 Thread Jon Smirl
On 7/1/08, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This is an I2S bus driver for the MPC5200 PSC device. It is probably > will not be merged as-is because it uses v1 of the ASoC API, but I want > to get it out there for comments. > --- > > sound/s

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-02 Thread Jon Smirl
DMA, needs to be split out. Efika is AC97 on the MPC5200 and needs to share DMA code. The new Phytec pcm030 baseboard is AC97 too. What does the device tree look like? On 7/1/08, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This is an I2S bus driver for t

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-02 Thread Liam Girdwood
On Tue, 2008-07-01 at 17:53 -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This is an I2S bus driver for the MPC5200 PSC device. It is probably > will not be merged as-is because it uses v1 of the ASoC API, but I want > to get it out there for comments. Looks good, just