Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-05-28 Thread Daniel Baluta
On Sun, Apr 21, 2019 at 11:26 AM Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 01:04:39AM -0700, Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > > > Firstly, according to your commit message, neither imx8qm nor > > > > imx6sx has an "mclk0" clock in the

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-04-21 Thread Daniel Baluta
On Sun, Apr 21, 2019 at 11:26 AM Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 01:04:39AM -0700, Nicolin Chen wrote: > > On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > > > Firstly, according to your commit message, neither imx8qm nor > > > > imx6sx has an "mclk0" clock in the

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-04-21 Thread Nicolin Chen
On Sun, Apr 21, 2019 at 01:04:39AM -0700, Nicolin Chen wrote: > On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > > Firstly, according to your commit message, neither imx8qm nor > > > imx6sx has an "mclk0" clock in the clock list. Either of them > > > starts with "mclk1". So, befor

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-04-21 Thread Nicolin Chen
On Sun, Apr 21, 2019 at 10:26:40AM +0300, Daniel Baluta wrote: > > Firstly, according to your commit message, neither imx8qm nor > > imx6sx has an "mclk0" clock in the clock list. Either of them > > starts with "mclk1". So, before you change the driver, I don't > > think it's even a right thing to

Re: [alsa-devel] [PATCH] ASoC: fsl: sai: Fix clock source for mclk0

2019-04-21 Thread Daniel Baluta
Hi Nicolin, Thanks for review! On Sun, Apr 21, 2019 at 8:39 AM Nicolin Chen wrote: > > By following the pattern of previous Subjects: > ASoC: fsl_sai: Fix clock Source for mclk0 I see. Will fix in v2. > > On Sat, Apr 20, 2019 at 03:41:04PM +, Daniel Baluta wrote: > > SAI provide multiple m