Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-12-12 Thread Paul Mackerras
On Thu, Dec 12, 2013 at 02:33:36PM -0600, Tom Musta wrote: > On 12/12/2013 9:08 AM, Tom Musta wrote: > > On 12/10/2013 10:57 PM, Paul Mackerras wrote: > >> On Wed, Dec 11, 2013 at 02:54:40PM +1100, Paul Mackerras wrote: > > > >>> This breaks 32-bit big-endian (as well as making the code longer and

Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-12-12 Thread Tom Musta
On 12/12/2013 9:08 AM, Tom Musta wrote: > On 12/10/2013 10:57 PM, Paul Mackerras wrote: >> On Wed, Dec 11, 2013 at 02:54:40PM +1100, Paul Mackerras wrote: > >>> This breaks 32-bit big-endian (as well as making the code longer and >>> more complex). >> >> And in fact none of this code will get exec

Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-12-12 Thread Tom Musta
On 12/10/2013 10:57 PM, Paul Mackerras wrote: > On Wed, Dec 11, 2013 at 02:54:40PM +1100, Paul Mackerras wrote: >> This breaks 32-bit big-endian (as well as making the code longer and >> more complex). > > And in fact none of this code will get executed in little-endian mode > anyway, since we st

Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-12-10 Thread Paul Mackerras
On Wed, Dec 11, 2013 at 02:54:40PM +1100, Paul Mackerras wrote: > On Thu, Oct 31, 2013 at 01:38:58PM -0500, Tom wrote: > > From: Tom Musta > > > > This patch addresses unaligned single precision floating point loads > > and stores in the single-step code. The old implementation > > improperly tr

Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-12-10 Thread Paul Mackerras
On Thu, Oct 31, 2013 at 01:38:58PM -0500, Tom wrote: > From: Tom Musta > > This patch addresses unaligned single precision floating point loads > and stores in the single-step code. The old implementation > improperly treated an 8 byte structure as an array of two 4 byte > words, which is a clas

Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-11-04 Thread Tom Musta
On 11/3/2013 8:34 PM, Benjamin Herrenschmidt wrote: > On Thu, 2013-10-31 at 13:38 -0500, Tom wrote: >> From: Tom Musta >> >> This patch addresses unaligned single precision floating point loads >> and stores in the single-step code. The old implementation >> improperly treated an 8 byte structure

Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-11-03 Thread Benjamin Herrenschmidt
On Thu, 2013-10-31 at 13:38 -0500, Tom wrote: > From: Tom Musta > > This patch addresses unaligned single precision floating point loads > and stores in the single-step code. The old implementation > improperly treated an 8 byte structure as an array of two 4 byte > words, which is a classic lit

[V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores

2013-10-31 Thread Tom
From: Tom Musta This patch addresses unaligned single precision floating point loads and stores in the single-step code. The old implementation improperly treated an 8 byte structure as an array of two 4 byte words, which is a classic little endian bug. Signed-off-by: Tom Musta --- arch/power