Re: [RFC v3 02/24] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-07-01 Thread Finn Thain
On Mon, 29 Jun 2015, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, Jun 28, 2015 at 3:42 AM, Finn Thain > wrote: > > Change the vmode calculation from logical OR to bitwise OR, since it > > is obviously wrong. > > Ideally, that should be a separate patch we can put on the fast track. If y

Re: [RFC v3 02/24] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-06-29 Thread Geert Uytterhoeven
Hi Finn, On Sun, Jun 28, 2015 at 3:42 AM, Finn Thain wrote: > Change the vmode calculation from logical OR to bitwise OR, since it is > obviously wrong. Ideally, that should be a separate patch we can put on the fast track. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

[RFC v3 02/24] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-06-27 Thread Finn Thain
Move the m68k-specific code elsewhere to make the driver generic. Change the vmode calculation from logical OR to bitwise OR, since it is obviously wrong. Signed-off-by: Finn Thain --- BTW, I didn't change the SCSI ID location in NVRAM. This code says 16 whereas atari_scsi says 14. Which one i