Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-13 Thread Neelesh Gupta
Hi Wolfram, Based on your patch: "[RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks" From: Neelesh Gupta Subject: [PATCH] i2c: opal: Update quirk flags to do write-then-anything Support write-then-anything in the case of 2 i2c messages for i2c transfer. Sig

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-12 Thread Wolfram Sang
> I think we can't land up here by-passing the check for quirks so above > checks are duplicated here.. True. So, as Ben seems OK with write-then-anything, can you send me your changes as an incremental patch to mine with your Signed-off, please? Thanks, Wolfram signature.asc Description

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-10 Thread Neelesh Gupta
On 03/11/2015 04:42 AM, Benjamin Herrenschmidt wrote: On Tue, 2015-03-10 at 22:43 +0530, Neelesh Gupta wrote: I tested the i2c opal driver after updating the patch as below. Basically I think we can also support write-then-{read/write} for the number of messages = 2. Ben, any issues if we suppo

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-10 Thread Benjamin Herrenschmidt
On Tue, 2015-03-10 at 22:43 +0530, Neelesh Gupta wrote: > I tested the i2c opal driver after updating the patch as below. > Basically I think we can also support write-then-{read/write} > for the number of messages = 2. > Ben, any issues if we support both write plus read/write in the > opal driver

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-03-10 Thread Neelesh Gupta
I tested the i2c opal driver after updating the patch as below. Basically I think we can also support write-then-{read/write} for the number of messages = 2. Ben, any issues if we support both write plus read/write in the opal driver ? Regards, Neelesh drivers/i2c/busses/i2c-opal.c | 20

[RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

2015-02-25 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-opal.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-opal.c b/drivers/i2c/busses/i2c-opal.c index 16f90b1a750894..b2788ecad5b3cb 100644 --- a/drivers/i