On Fri, 5 Mar 2021 at 12:49, Michael Ellerman wrote:
> Marco Elver writes:
> ...
> >
> > The choice is between:
> >
> > 1. ARCH_FUNC_PREFIX (as a matter of fact, the ARCH_FUNC_PREFIX patch
> > is already in -mm). Perhaps we could optimize it further, by checking
> > ARCH_FUNC_PREFIX in buf, and a
Marco Elver writes:
...
>
> The choice is between:
>
> 1. ARCH_FUNC_PREFIX (as a matter of fact, the ARCH_FUNC_PREFIX patch
> is already in -mm). Perhaps we could optimize it further, by checking
> ARCH_FUNC_PREFIX in buf, and advancing buf like you propose, but I'm
> not sure it's worth worrying
Marco Elver writes:
> On Thu, Mar 04, 2021 at 12:48PM +0100, Christophe Leroy wrote:
>> Le 04/03/2021 à 12:31, Marco Elver a écrit :
>> > On Thu, 4 Mar 2021 at 12:23, Christophe Leroy
>> > wrote:
>> > > Le 03/03/2021 à 11:56, Marco Elver a écrit :
>> > > >
>> > > > Somewhat tangentially, I also
On Thu, 4 Mar 2021 at 15:08, Christophe Leroy
wrote:
>
>
>
> Le 04/03/2021 à 13:48, Marco Elver a écrit :
> > From d118080eb9552073f5dcf1f86198f3d86d5ea850 Mon Sep 17 00:00:00 2001
> > From: Marco Elver
> > Date: Thu, 4 Mar 2021 13:15:51 +0100
> > Subject: [PATCH] kfence: fix reports if constant
On Thu, Mar 04, 2021 at 12:48PM +0100, Christophe Leroy wrote:
> Le 04/03/2021 à 12:31, Marco Elver a écrit :
> > On Thu, 4 Mar 2021 at 12:23, Christophe Leroy
> > wrote:
> > > Le 03/03/2021 à 11:56, Marco Elver a écrit :
> > > >
> > > > Somewhat tangentially, I also note that e.g. show_regs(regs
On Thu, 4 Mar 2021 at 13:00, Christophe Leroy
wrote:
>
>
>
> Le 04/03/2021 à 12:48, Christophe Leroy a écrit :
> >
> >
> > Le 04/03/2021 à 12:31, Marco Elver a écrit :
> >> On Thu, 4 Mar 2021 at 12:23, Christophe Leroy
> >> wrote:
> >>> Le 03/03/2021 à 11:56, Marco Elver a écrit :
>
> S
On Thu, 4 Mar 2021 at 12:23, Christophe Leroy
wrote:
> Le 03/03/2021 à 11:56, Marco Elver a écrit :
> >
> > Somewhat tangentially, I also note that e.g. show_regs(regs) (which
> > was printed along the KFENCE report above) didn't include the top
> > frame in the "Call Trace", so this assumption is
Le 04/03/2021 à 13:48, Marco Elver a écrit :
From d118080eb9552073f5dcf1f86198f3d86d5ea850 Mon Sep 17 00:00:00 2001
From: Marco Elver
Date: Thu, 4 Mar 2021 13:15:51 +0100
Subject: [PATCH] kfence: fix reports if constant function prefixes exist
Some architectures prefix all functions with a
Le 04/03/2021 à 12:48, Christophe Leroy a écrit :
Le 04/03/2021 à 12:31, Marco Elver a écrit :
On Thu, 4 Mar 2021 at 12:23, Christophe Leroy
wrote:
Le 03/03/2021 à 11:56, Marco Elver a écrit :
Somewhat tangentially, I also note that e.g. show_regs(regs) (which
was printed along the KFEN
Le 04/03/2021 à 12:31, Marco Elver a écrit :
On Thu, 4 Mar 2021 at 12:23, Christophe Leroy
wrote:
Le 03/03/2021 à 11:56, Marco Elver a écrit :
Somewhat tangentially, I also note that e.g. show_regs(regs) (which
was printed along the KFENCE report above) didn't include the top
frame in the
Le 03/03/2021 à 11:56, Marco Elver a écrit :
Somewhat tangentially, I also note that e.g. show_regs(regs) (which
was printed along the KFENCE report above) didn't include the top
frame in the "Call Trace", so this assumption is definitely not
isolated to KFENCE.
Now, I have tested PPC64 (w
On Wed, 3 Mar 2021 at 11:39, Christophe Leroy
wrote:
>
>
>
> Le 02/03/2021 à 12:39, Marco Elver a écrit :
> > On Tue, 2 Mar 2021 at 12:21, Christophe Leroy
> > wrote:
> > [...]
> Booting with 'no_hash_pointers" I get the following. Does it helps ?
>
> [ 16.837198]
> ===
On Wed, 3 Mar 2021 at 11:32, Christophe Leroy
wrote:
>
>
>
> Le 02/03/2021 à 10:53, Marco Elver a écrit :
> > On Tue, 2 Mar 2021 at 10:27, Christophe Leroy
> > wrote:
> >> Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
> [ 14.998426] BUG: KFENCE: invalid read in
> finish_task_s
On Mär 03 2021, Marco Elver wrote:
> On Wed, 3 Mar 2021 at 11:32, Christophe Leroy
> wrote:
>> ./include/linux/kern_levels.h:5:18: warning: format '%zd' expects argument
>> of type 'signed size_t',
>> but argument 3 has type 'ptrdiff_t' {aka 'const long int'} [-Wformat=]
>> 5 | #define KERN
Le 03/03/2021 à 11:39, Marco Elver a écrit :
On Wed, 3 Mar 2021 at 11:32, Christophe Leroy
wrote:
Le 02/03/2021 à 10:53, Marco Elver a écrit :
On Tue, 2 Mar 2021 at 10:27, Christophe Leroy
wrote:
Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
[ 14.998426] BUG: KFENCE: invalid
Le 02/03/2021 à 12:39, Marco Elver a écrit :
On Tue, 2 Mar 2021 at 12:21, Christophe Leroy
wrote:
[...]
Booting with 'no_hash_pointers" I get the following. Does it helps ?
[ 16.837198]
==
[ 16.848521] BUG: KFENCE: invalid
Le 02/03/2021 à 10:53, Marco Elver a écrit :
On Tue, 2 Mar 2021 at 10:27, Christophe Leroy
wrote:
Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
[ 14.998426] BUG: KFENCE: invalid read in finish_task_switch.isra.0+0x54/0x23c
[ 14.998426]
[ 15.007061] Invalid read at 0x(ptrval):
[
Le 02/03/2021 à 12:40, Michael Ellerman a écrit :
Christophe Leroy writes:
Le 02/03/2021 à 10:53, Marco Elver a écrit :
On Tue, 2 Mar 2021 at 10:27, Christophe Leroy
wrote:
Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
[ 14.998426] BUG: KFENCE: invalid read in finish_task_switch
On Tue, Mar 02, 2021 at 10:40:03PM +1100, Michael Ellerman wrote:
> >> -- Change the unwinder, if it's possible for ppc32.
> >
> > I don't think it is possible.
>
> I think this actually is the solution.
>
> It seems the good architectures have all added support for
> arch_stack_walk(), and we ha
On Tue, 2 Mar 2021 at 12:21, Christophe Leroy
wrote:
[...]
> >> Booting with 'no_hash_pointers" I get the following. Does it helps ?
> >>
> >> [ 16.837198]
> >> ==
> >> [ 16.848521] BUG: KFENCE: invalid read in
> >> finish_task_
On Tue, 2 Mar 2021 at 10:27, Christophe Leroy
wrote:
> Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
> >> [ 14.998426] BUG: KFENCE: invalid read in
> >> finish_task_switch.isra.0+0x54/0x23c
> >> [ 14.998426]
> >> [ 15.007061] Invalid read at 0x(ptrval):
> >> [ 15.010906] finish_ta
> [ 14.998426] BUG: KFENCE: invalid read in
> finish_task_switch.isra.0+0x54/0x23c
> [ 14.998426]
> [ 15.007061] Invalid read at 0x(ptrval):
> [ 15.010906] finish_task_switch.isra.0+0x54/0x23c
> [ 15.015633] kunit_try_run_case+0x5c/0xd0
> [ 15.019682] kunit_generic_run_threadfn_adap
On Tue, 2 Mar 2021 at 09:37, Christophe Leroy
wrote:
> Add architecture specific implementation details for KFENCE and enable
> KFENCE for the ppc32 architecture. In particular, this implements the
> required interface in .
Nice!
> KFENCE requires that attributes for pages from its memory pool c
Christophe Leroy writes:
> Le 02/03/2021 à 10:53, Marco Elver a écrit :
>> On Tue, 2 Mar 2021 at 10:27, Christophe Leroy
>> wrote:
>>> Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
> [ 14.998426] BUG: KFENCE: invalid read in
> finish_task_switch.isra.0+0x54/0x23c
> [ 14.99
Le 02/03/2021 à 10:53, Marco Elver a écrit :
On Tue, 2 Mar 2021 at 10:27, Christophe Leroy
wrote:
Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
[ 14.998426] BUG: KFENCE: invalid read in finish_task_switch.isra.0+0x54/0x23c
[ 14.998426]
[ 15.007061] Invalid read at 0x(ptrval):
[
Le 02/03/2021 à 10:21, Alexander Potapenko a écrit :
[ 14.998426] BUG: KFENCE: invalid read in finish_task_switch.isra.0+0x54/0x23c
[ 14.998426]
[ 15.007061] Invalid read at 0x(ptrval):
[ 15.010906] finish_task_switch.isra.0+0x54/0x23c
[ 15.015633] kunit_try_run_case+0x5c/0xd0
[
Le 02/03/2021 à 09:58, Marco Elver a écrit :
On Tue, 2 Mar 2021 at 09:37, Christophe Leroy
wrote:
Add architecture specific implementation details for KFENCE and enable
KFENCE for the ppc32 architecture. In particular, this implements the
required interface in .
Nice!
KFENCE requires tha
Add architecture specific implementation details for KFENCE and enable
KFENCE for the ppc32 architecture. In particular, this implements the
required interface in .
KFENCE requires that attributes for pages from its memory pool can
individually be set. Therefore, force the Read/Write linear map to
28 matches
Mail list logo
