Re: [Fwd: [RFC PATCH 4/5] hvc_console: Add tty window resizing]

2008-10-20 Thread Benjamin Herrenschmidt
On Tue, 2008-10-21 at 10:21 +1100, Benjamin Herrenschmidt wrote: > Didn't make it to patchwork initially, resending. Ignore me, it made it and was superseeded... Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/lis

[Fwd: [RFC PATCH 4/5] hvc_console: Add tty window resizing]

2008-10-20 Thread Benjamin Herrenschmidt
]>, Ryan S. Arnold <[EMAIL PROTECTED]> Cc: LKML <[EMAIL PROTECTED]>, Christian Borntraeger <[EMAIL PROTECTED]>, Heiko Carstens <[EMAIL PROTECTED]>, Martin Schwidefsky <[EMAIL PROTECTED]>, Hendrik Brueckner <[EMAIL PROTECTED]> Subject: [RFC PATCH 4/5] hvc_console

Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

2008-10-16 Thread Christian Borntraeger
Am Donnerstag, 16. Oktober 2008 schrieb Rusty Russell: > > The patch provides the hvc_resize() function to update the terminal > > window dimensions (struct winsize) for a specified hvc console. > > The function stores the new window size and schedules a function > > that finally updates the tty wi

Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

2008-10-16 Thread Rusty Russell
On Tuesday 14 October 2008 20:12:51 Hendrik Brueckner wrote: > From: Hendrik Brueckner <[EMAIL PROTECTED]> > > The patch provides the hvc_resize() function to update the terminal > window dimensions (struct winsize) for a specified hvc console. > The function stores the new window size and schedule

Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

2008-10-14 Thread Alan Cox
> Since tty_do_resize() cannot be called holding the hp spinlock; the code uses > now tty_kref_get/put to keep track of the tty object. I am not sure if the > use of the kref's is correct here, so please let me know if there is a better > solution. That looks right to me, hp->tty can go NULL but t

Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

2008-10-14 Thread Hendrik Brueckner
On Tue, Oct 14, 2008 at 10:44:28AM +0100, Alan Cox wrote: > > + hp = container_of(work, struct hvc_struct, tty_resize); > > + if (!hp || !hp->tty) > > + return; > What locks hp->tty here, it can go NULL after the test on a hangup it > seems ? You are right. Thanks. > See tty_do_resiz

[RFC PATCH 4/5] hvc_console: Add tty window resizing

2008-10-14 Thread Hendrik Brueckner
From: Hendrik Brueckner <[EMAIL PROTECTED]> The patch provides the hvc_resize() function to update the terminal window dimensions (struct winsize) for a specified hvc console. The function stores the new window size and schedules a function that finally updates the tty winsize and signals the chan

Re: [RFC PATCH 4/5] hvc_console: Add tty window resizing

2008-10-14 Thread Alan Cox
> + hp = container_of(work, struct hvc_struct, tty_resize); > + if (!hp || !hp->tty) > + return; What locks hp->tty here, it can go NULL after the test on a hangup it seems ? > + * hvc_resize() - Update terminal window size information. > + * @hp: HVC console poin