Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-05-22 Thread Naveen N. Rao
Peter Zijlstra wrote: On Sat, May 21, 2022 at 09:38:35AM +, Christophe Leroy wrote: I gave it a try this morning, I selected HAVE_OBJTOOL and HAVE_OBJTOOL_MCOUNT from arch/powerpc/Kconfig Seems like there are still some x86 arch specific stuff in common common code and I get the followi

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-05-21 Thread Peter Zijlstra
On Sat, May 21, 2022 at 09:38:35AM +, Christophe Leroy wrote: > I gave it a try this morning, I selected HAVE_OBJTOOL and > HAVE_OBJTOOL_MCOUNT from arch/powerpc/Kconfig > > > Seems like there are still some x86 arch specific stuff in common common > code and I get the following errors. I

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-05-21 Thread Christophe Leroy
Le 12/05/2022 à 17:12, Josh Poimboeuf a écrit : > On Thu, May 12, 2022 at 02:52:40PM +, Christophe Leroy wrote: >> Hi Josh, >> >> Le 28/03/2022 à 21:59, Josh Poimboeuf a écrit : >>> On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: What are current works in progress on objt

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-05-12 Thread Josh Poimboeuf
On Thu, May 12, 2022 at 02:52:40PM +, Christophe Leroy wrote: > Hi Josh, > > Le 28/03/2022 à 21:59, Josh Poimboeuf a écrit : > > On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: > >> What are current works in progress on objtool ? Should I wait Josh's > >> changes before start

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-05-12 Thread Christophe Leroy
Hi Josh, Le 28/03/2022 à 21:59, Josh Poimboeuf a écrit : > On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: >> What are current works in progress on objtool ? Should I wait Josh's >> changes before starting looking at all this ? Should I wait for anything >> else ? > > I'm not ma

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-30 Thread Naveen N. Rao
Christophe Leroy wrote: Le 29/03/2022 à 14:01, Michael Ellerman a écrit : Josh Poimboeuf writes: On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: What are current works in progress on objtool ? Should I wait Josh's changes before starting looking at all this ? Should I wait

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-29 Thread Josh Poimboeuf
On Tue, Mar 29, 2022 at 05:32:18PM +, Christophe Leroy wrote: > > > Le 29/03/2022 à 14:01, Michael Ellerman a écrit : > > Josh Poimboeuf writes: > >> On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: > >>> Second point is the endianess and 32/64 selection, especially when > >

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-29 Thread Christophe Leroy
Le 29/03/2022 à 14:01, Michael Ellerman a écrit : > Josh Poimboeuf writes: >> On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: >>> Second point is the endianess and 32/64 selection, especially when >>> crossbuilding. There is already some stuff regarding endianess based on >>> b

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-29 Thread Michael Ellerman
Josh Poimboeuf writes: > On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: >> Second point is the endianess and 32/64 selection, especially when >> crossbuilding. There is already some stuff regarding endianess based on >> bswap_if_needed() but that's based on constant selection

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Josh Poimboeuf
On Mon, Mar 28, 2022 at 10:14:38PM +0200, Peter Zijlstra wrote: > > FWIW, there have been some objtool patches for arm64 stack validation, > > but the arm64 maintainers have been hesitant to get on board with > > objtool, as it brings a certain maintenance burden. Especially for the > > full stack

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Peter Zijlstra
+arm64 people... On Mon, Mar 28, 2022 at 10:14:38PM +0200, Peter Zijlstra wrote: > On Mon, Mar 28, 2022 at 12:59:20PM -0700, Josh Poimboeuf wrote: > > > I'm not making any major changes to the code, just shuffling things > > around to make the interface more modular. I hope to have something >

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Peter Zijlstra
On Mon, Mar 28, 2022 at 12:59:20PM -0700, Josh Poimboeuf wrote: > I'm not making any major changes to the code, just shuffling things > around to make the interface more modular. I hope to have something > soon (this week). Peter recently added a big feature (Intel IBT) which > is already in -ne

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-28 Thread Josh Poimboeuf
On Sun, Mar 27, 2022 at 09:09:20AM +, Christophe Leroy wrote: > Second point is the endianess and 32/64 selection, especially when > crossbuilding. There is already some stuff regarding endianess based on > bswap_if_needed() but that's based on constant selection at build time > and I couldn

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-27 Thread Christophe Leroy
Hi Peter, Hi Josh Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : > On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: >> This patch adds powerpc specific functions required for >> 'objtool mcount' to work, and enables mcount for ppc. > > I would love to see more objtool enableme

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-26 Thread Christophe Leroy
Le 21/03/2022 a 08:56, Christophe Leroy a ecrit : > > > Le 21/03/2022 a 03:27, Michael Ellerman a ecrit : >> Christophe Leroy writes: >>> Le 18/03/2022 a 13:26, Peter Zijlstra a ecrit : On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: > This patch adds powerpc specifi

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-21 Thread Christophe Leroy
Le 21/03/2022 à 09:30, Christophe Leroy a écrit : Le 21/03/2022 à 08:56, Christophe Leroy a écrit : Le 21/03/2022 à 03:27, Michael Ellerman a écrit : Christophe Leroy writes: Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy w

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-21 Thread Christophe Leroy
Le 21/03/2022 à 08:56, Christophe Leroy a écrit : Le 21/03/2022 à 03:27, Michael Ellerman a écrit : Christophe Leroy writes: Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: This patch adds powerpc specific functions req

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-21 Thread Christophe Leroy
Le 21/03/2022 à 03:27, Michael Ellerman a écrit : > Christophe Leroy writes: >> Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : >>> On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: This patch adds powerpc specific functions required for 'objtool mcount' to work, and

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-21 Thread Christophe Leroy
Le 21/03/2022 à 03:27, Michael Ellerman a écrit : > Christophe Leroy writes: >> Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : >>> On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: This patch adds powerpc specific functions required for 'objtool mcount' to work, and

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-20 Thread Christophe Leroy
Le 21/03/2022 à 03:27, Michael Ellerman a écrit : > Christophe Leroy writes: >> Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : >>> On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: This patch adds powerpc specific functions required for 'objtool mcount' to work, and

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-20 Thread Naveen N. Rao
Peter Zijlstra wrote: On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: This patch adds powerpc specific functions required for 'objtool mcount' to work, and enables mcount for ppc. I would love to see more objtool enablement for Power :-) diff --git a/tools/objtool/arch/p

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-20 Thread Michael Ellerman
Christophe Leroy writes: > Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : >> On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: >>> This patch adds powerpc specific functions required for >>> 'objtool mcount' to work, and enables mcount for ppc. >> >> I would love to see more ob

[RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-18 Thread Sathvika Vasireddy
This patch adds powerpc specific functions required for 'objtool mcount' to work, and enables mcount for ppc. Signed-off-by: Sathvika Vasireddy --- arch/powerpc/Kconfig | 1 + tools/objtool/Makefile| 4 ++ tools/objtool/arch/powerpc/Build

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-18 Thread Christophe Leroy
Hi, Le 18/03/2022 à 13:26, Peter Zijlstra a écrit : > On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: >> This patch adds powerpc specific functions required for >> 'objtool mcount' to work, and enables mcount for ppc. > > I would love to see more objtool enablement for Power :

Re: [RFC PATCH 3/3] objtool/mcount: Add powerpc specific functions

2022-03-18 Thread Peter Zijlstra
On Fri, Mar 18, 2022 at 04:21:40PM +0530, Sathvika Vasireddy wrote: > This patch adds powerpc specific functions required for > 'objtool mcount' to work, and enables mcount for ppc. I would love to see more objtool enablement for Power :-) > diff --git a/tools/objtool/arch/powerpc/include/arch/e