Re: [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory

2012-06-27 Thread Yasuaki Ishimatsu
Hi Wen, 2012/06/28 12:25, Wen Congyang wrote: > At 06/28/2012 11:01 AM, Yasuaki Ishimatsu Wrote: >> Hi David and Wen, >> >> Thank you for reviewing my patch. >> >> 2012/06/27 17:47, Wen Congyang wrote: >>> At 06/27/2012 03:14 PM, Wen Congyang Wrote: At 06/27/2012 01:42 PM, Yasuaki Ishimatsu W

Re: [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory

2012-06-27 Thread Wen Congyang
At 06/28/2012 11:01 AM, Yasuaki Ishimatsu Wrote: > Hi David and Wen, > > Thank you for reviewing my patch. > > 2012/06/27 17:47, Wen Congyang wrote: >> At 06/27/2012 03:14 PM, Wen Congyang Wrote: >>> At 06/27/2012 01:42 PM, Yasuaki Ishimatsu Wrote: remove_memory() does not remove memory but

Re: [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory

2012-06-27 Thread Yasuaki Ishimatsu
Hi David and Wen, Thank you for reviewing my patch. 2012/06/27 17:47, Wen Congyang wrote: > At 06/27/2012 03:14 PM, Wen Congyang Wrote: >> At 06/27/2012 01:42 PM, Yasuaki Ishimatsu Wrote: >>> remove_memory() does not remove memory but just offlines memory. The patch >>> changes name of it to offl

Re: [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory

2012-06-27 Thread Wen Congyang
At 06/27/2012 03:14 PM, Wen Congyang Wrote: > At 06/27/2012 01:42 PM, Yasuaki Ishimatsu Wrote: >> remove_memory() does not remove memory but just offlines memory. The patch >> changes name of it to offline_memory(). > > There are 3 functions in the kernel: > 1. add_memory() > 2. online_pages() > 3

Re: [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory

2012-06-27 Thread Wen Congyang
At 06/27/2012 01:42 PM, Yasuaki Ishimatsu Wrote: > remove_memory() does not remove memory but just offlines memory. The patch > changes name of it to offline_memory(). There are 3 functions in the kernel: 1. add_memory() 2. online_pages() 3. remove_memory() So I think offline_pages() is better th

[RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory

2012-06-27 Thread Yasuaki Ishimatsu
remove_memory() does not remove memory but just offlines memory. The patch changes name of it to offline_memory(). CC: Len Brown CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Christoph Lameter Cc: Minchan Kim CC: Andrew Morton CC: KOSAKI Motohiro CC: Wen Congyang Signed-off-by: Yasuaki

Re: [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory

2012-06-26 Thread David Rientjes
On Wed, 27 Jun 2012, Yasuaki Ishimatsu wrote: > remove_memory() does not remove memory but just offlines memory. The patch > changes name of it to offline_memory(). > The kernel is never going to physically remove the memory itself, so I don't see the big problem with calling it remove_memory()