Re: [RFC PATCH 08/11] powerpc/tm: Do not reclaim on ptrace

2018-09-30 Thread Michael Neuling
On Sun, 2018-09-30 at 20:51 -0300, Breno Leitao wrote: > Hi Mikey, > > On 09/28/2018 02:36 AM, Michael Neuling wrote: > > > > > + WARN_ON(MSR_TM_SUSPENDED(mfmsr())); + + tm_enable(); + > > > > > tm_save_sprs(&(tsk->thread)); > > > > > > > > Do we need to check if TM was enabled in the task b

Re: [RFC PATCH 08/11] powerpc/tm: Do not reclaim on ptrace

2018-09-30 Thread Breno Leitao
Hi Mikey, On 09/28/2018 02:36 AM, Michael Neuling wrote: + WARN_ON(MSR_TM_SUSPENDED(mfmsr())); + + tm_enable(); + tm_save_sprs(&(tsk->thread)); >>> >>> Do we need to check if TM was enabled in the task before saving the >>> TM SPRs? >>> >>> What happens if TM was lazily off and hence

Re: [RFC PATCH 08/11] powerpc/tm: Do not reclaim on ptrace

2018-09-27 Thread Michael Neuling
On Thu, 2018-09-27 at 18:03 -0300, Breno Leitao wrote: > Hi Mikey, > > On 09/18/2018 02:36 AM, Michael Neuling wrote: > > On Wed, 2018-09-12 at 16:40 -0300, Breno Leitao wrote: > > > Make sure that we are not suspended on ptrace and that the registers were > > > already reclaimed. > > > > > > Sin

Re: [RFC PATCH 08/11] powerpc/tm: Do not reclaim on ptrace

2018-09-27 Thread Breno Leitao
Hi Mikey, On 09/18/2018 02:36 AM, Michael Neuling wrote: > On Wed, 2018-09-12 at 16:40 -0300, Breno Leitao wrote: >> Make sure that we are not suspended on ptrace and that the registers were >> already reclaimed. >> >> Since the data was already reclaimed, there is nothing to be done here >> excep

Re: [RFC PATCH 08/11] powerpc/tm: Do not reclaim on ptrace

2018-09-17 Thread Michael Neuling
On Wed, 2018-09-12 at 16:40 -0300, Breno Leitao wrote: > Make sure that we are not suspended on ptrace and that the registers were > already reclaimed. > > Since the data was already reclaimed, there is nothing to be done here > except to restore the SPRs. > > Signed-off-by: Breno Leitao > --- >

[RFC PATCH 08/11] powerpc/tm: Do not reclaim on ptrace

2018-09-12 Thread Breno Leitao
Make sure that we are not suspended on ptrace and that the registers were already reclaimed. Since the data was already reclaimed, there is nothing to be done here except to restore the SPRs. Signed-off-by: Breno Leitao --- arch/powerpc/kernel/ptrace.c | 10 -- 1 file changed, 4 inserti