Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-27 Thread Segher Boessenkool
Add a config option GAMECUBE_COMMON to be used as a dependency for all options common to the Nintendo GameCube and Wii video game consoles. Maybe something like GAMECUBE_OR_WII instead? "COMMON" is so common it's meaningless. I don't like either GAMECUBE_OR_WII. It looks as if it can be us

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-26 Thread Albert Herranz
Benjamin Herrenschmidt wrote: > On Tue, 2009-11-24 at 19:03 +0100, Albert Herranz wrote: >> Segher Boessenkool wrote: Add a config option GAMECUBE_COMMON to be used as a dependency for all options common to the Nintendo GameCube and Wii video game consoles. >>> Maybe something like GAMECU

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-25 Thread Benjamin Herrenschmidt
On Tue, 2009-11-24 at 19:03 +0100, Albert Herranz wrote: > Segher Boessenkool wrote: > >> Add a config option GAMECUBE_COMMON to be used as a dependency for all > >> options common to the Nintendo GameCube and Wii video game consoles. > > > > Maybe something like GAMECUBE_OR_WII instead? "COMMON"

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-25 Thread Albert Herranz
Segher Boessenkool wrote: >> If GAMECUBE_COMMON is unacceptable, maybe GAMECUBE_LEGACY or >> GAMECUBE_COMPAT? > > Maybe it's best to write GAMECUBE || WII in the places that use it, then? > That gets messy in conditionals, like for example: config PCI bool "PCI support" if PPC_PCI_CHOI

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-24 Thread Arnd Bergmann
On Tuesday 24 November 2009, Segher Boessenkool wrote: > > This option should be used only for options applicable to both the > > GAMECUBE and WII, i.e. basically those options in the WII which > > where "inherited" from the GAMECUBE to make it retro-compatible. > > > > If GAMECUBE_COMMON is un

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-24 Thread Segher Boessenkool
Add a config option GAMECUBE_COMMON to be used as a dependency for all options common to the Nintendo GameCube and Wii video game consoles. Maybe something like GAMECUBE_OR_WII instead? "COMMON" is so common it's meaningless. I don't like either GAMECUBE_OR_WII. It looks as if it can be us

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-24 Thread Albert Herranz
Segher Boessenkool wrote: >> Add a config option GAMECUBE_COMMON to be used as a dependency for all >> options common to the Nintendo GameCube and Wii video game consoles. > > Maybe something like GAMECUBE_OR_WII instead? "COMMON" is so > common it's meaningless. > I don't like either GAMECUBE_

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-23 Thread Segher Boessenkool
Add a config option GAMECUBE_COMMON to be used as a dependency for all options common to the Nintendo GameCube and Wii video game consoles. Maybe something like GAMECUBE_OR_WII instead? "COMMON" is so common it's meaningless. Segher ___ Linuxppc-de

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-23 Thread Albert Herranz
Grant Likely wrote: > On Sun, Nov 22, 2009 at 3:01 PM, Albert Herranz > wrote: >> Add a config option GAMECUBE_COMMON to be used as a dependency for all >> options common to the Nintendo GameCube and Wii video game consoles. >> >> Signed-off-by: Albert Herranz > > This could just be rolled into

Re: [RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-22 Thread Grant Likely
On Sun, Nov 22, 2009 at 3:01 PM, Albert Herranz wrote: > Add a config option GAMECUBE_COMMON to be used as a dependency for all > options common to the Nintendo GameCube and Wii video game consoles. > > Signed-off-by: Albert Herranz This could just be rolled into the first patch that uses it. B

[RFC PATCH 06/19] powerpc: gamecube/wii: introduce GAMECUBE_COMMON

2009-11-22 Thread Albert Herranz
Add a config option GAMECUBE_COMMON to be used as a dependency for all options common to the Nintendo GameCube and Wii video game consoles. Signed-off-by: Albert Herranz --- arch/powerpc/platforms/embedded6xx/Kconfig |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arc