Re: [RFC PATCH 02/12] powerpc: remove arguments from interrupt handler functions

2020-09-08 Thread Christophe Leroy
Le 08/09/2020 à 10:29, Christophe Leroy a écrit : Le 08/09/2020 à 09:48, Nicholas Piggin a écrit : Excerpts from Christophe Leroy's message of September 7, 2020 9:34 pm: On Mon, 2020-09-07 at 11:20 +0200, Christophe Leroy wrote: Le 05/09/2020 à 19:43, Nicholas Piggin a écrit : Make inte

Re: [RFC PATCH 02/12] powerpc: remove arguments from interrupt handler functions

2020-09-08 Thread Christophe Leroy
Le 08/09/2020 à 09:48, Nicholas Piggin a écrit : Excerpts from Christophe Leroy's message of September 7, 2020 9:34 pm: On Mon, 2020-09-07 at 11:20 +0200, Christophe Leroy wrote: Le 05/09/2020 à 19:43, Nicholas Piggin a écrit : Make interrupt handlers all just take the pt_regs * argument a

Re: [RFC PATCH 02/12] powerpc: remove arguments from interrupt handler functions

2020-09-08 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of September 7, 2020 9:34 pm: > On Mon, 2020-09-07 at 11:20 +0200, Christophe Leroy wrote: >> >> Le 05/09/2020 à 19:43, Nicholas Piggin a écrit : >> > Make interrupt handlers all just take the pt_regs * argument and load >> > DAR/DSISR etc from that. Make t

Re: [RFC PATCH 02/12] powerpc: remove arguments from interrupt handler functions

2020-09-08 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of September 7, 2020 7:20 pm: > > > Le 05/09/2020 à 19:43, Nicholas Piggin a écrit : >> Make interrupt handlers all just take the pt_regs * argument and load >> DAR/DSISR etc from that. Make those that return a value return long. > > I like this, it will

Re: [RFC PATCH 02/12] powerpc: remove arguments from interrupt handler functions

2020-09-07 Thread Christophe Leroy
On Mon, 2020-09-07 at 11:20 +0200, Christophe Leroy wrote: > > Le 05/09/2020 à 19:43, Nicholas Piggin a écrit : > > Make interrupt handlers all just take the pt_regs * argument and load > > DAR/DSISR etc from that. Make those that return a value return long. > > I like this, it will likely simpli

Re: [RFC PATCH 02/12] powerpc: remove arguments from interrupt handler functions

2020-09-07 Thread Christophe Leroy
Le 05/09/2020 à 19:43, Nicholas Piggin a écrit : Make interrupt handlers all just take the pt_regs * argument and load DAR/DSISR etc from that. Make those that return a value return long. I like this, it will likely simplify a bit the VMAP_STACK mess. Not sure it is that easy. My board is s

[RFC PATCH 02/12] powerpc: remove arguments from interrupt handler functions

2020-09-05 Thread Nicholas Piggin
Make interrupt handlers all just take the pt_regs * argument and load DAR/DSISR etc from that. Make those that return a value return long. This is done to make the function signatures match more closely, which will help with a future patch to add wrappers. Explicit arguments could be re-added for