Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-06-14 Thread David Hildenbrand
On 02.06.21 17:56, Zi Yan wrote: On 10 May 2021, at 10:36, Zi Yan wrote: On 7 May 2021, at 10:00, David Hildenbrand wrote: On 07.05.21 13:55, Michal Hocko wrote: [I haven't read through respective patches due to lack of time but let me comment on the general idea and the underlying justif

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-06-02 Thread Zi Yan
On 10 May 2021, at 10:36, Zi Yan wrote: > On 7 May 2021, at 10:00, David Hildenbrand wrote: > >> On 07.05.21 13:55, Michal Hocko wrote: >>> [I haven't read through respective patches due to lack of time but let >>> me comment on the general idea and the underlying justification] >>> >>> On Thu 0

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-12 Thread David Hildenbrand
As stated somewhere here already, we'll have to look into making alloc_contig_range() (and main users CMA and virtio-mem) independent of MAX_ORDER and mainly rely on pageblock_order. The current handling in alloc_contig_range() is far from optimal as we have to isolate a whole MAX_ORDER - 1 p

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-10 Thread Zi Yan
On 7 May 2021, at 10:00, David Hildenbrand wrote: > On 07.05.21 13:55, Michal Hocko wrote: >> [I haven't read through respective patches due to lack of time but let >> me comment on the general idea and the underlying justification] >> >> On Thu 06-05-21 17:31:09, David Hildenbrand wrote: >>> On

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-07 Thread Michal Hocko
[I haven't read through respective patches due to lack of time but let me comment on the general idea and the underlying justification] On Thu 06-05-21 17:31:09, David Hildenbrand wrote: > On 06.05.21 17:26, Zi Yan wrote: > > From: Zi Yan > > > > Hi all, > > > > This patchset tries to remove t

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-07 Thread David Hildenbrand
On 07.05.21 13:55, Michal Hocko wrote: [I haven't read through respective patches due to lack of time but let me comment on the general idea and the underlying justification] On Thu 06-05-21 17:31:09, David Hildenbrand wrote: On 06.05.21 17:26, Zi Yan wrote: From: Zi Yan Hi all, This patc

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread David Hildenbrand
On 06.05.21 21:30, Matthew Wilcox wrote: On Thu, May 06, 2021 at 09:10:52PM +0200, David Hildenbrand wrote: I have to admit that I am not really a friend of that. I still think our target goal should be to have gigantic THP *in addition to* ordinary THP. Use gigantic THP where enabled and possib

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread Matthew Wilcox
On Thu, May 06, 2021 at 09:10:52PM +0200, David Hildenbrand wrote: > I have to admit that I am not really a friend of that. I still think our > target goal should be to have gigantic THP *in addition to* ordinary THP. > Use gigantic THP where enabled and possible, and just use ordinary THP > everyw

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread David Hildenbrand
1. Pageblock size There are a couple of features that rely on the pageblock size to be reasonably small to work as expected. One example is virtio-balloon free page reporting, then there is virtio-mem (still also glued MAX_ORDER) and we have CMA (still also glued to MAX_ORDER). Most probably

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread Zi Yan
On 6 May 2021, at 12:28, David Hildenbrand wrote: > On 06.05.21 17:50, Zi Yan wrote: >> On 6 May 2021, at 11:40, David Hildenbrand wrote: >> >> The last patch increases SECTION_SIZE_BITS to demonstrate the use of >> memory >> hotplug/hotremove subsection, but is not intended to be mer

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread David Hildenbrand
On 06.05.21 17:50, Zi Yan wrote: On 6 May 2021, at 11:40, David Hildenbrand wrote: The last patch increases SECTION_SIZE_BITS to demonstrate the use of memory hotplug/hotremove subsection, but is not intended to be merged as is. It is there in case one wants to try this out and will be removed

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread Zi Yan
On 6 May 2021, at 11:40, David Hildenbrand wrote: The last patch increases SECTION_SIZE_BITS to demonstrate the use of memory hotplug/hotremove subsection, but is not intended to be merged as is. It is there in case one wants to try this out and will be removed during the fina

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread Zi Yan
On 6 May 2021, at 11:26, Zi Yan wrote: > From: Zi Yan > > Hi all, > > This patchset tries to remove the restriction on memory hotplug/hotremove > granularity, which is always greater or equal to memory section size[1]. > With the patchset, kernel is able to online/offline memory at a size > inde

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread David Hildenbrand
The last patch increases SECTION_SIZE_BITS to demonstrate the use of memory hotplug/hotremove subsection, but is not intended to be merged as is. It is there in case one wants to try this out and will be removed during the final submission. Feel free to give suggestions and comments. I am looking

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread David Hildenbrand
On 06.05.21 17:31, David Hildenbrand wrote: On 06.05.21 17:26, Zi Yan wrote: From: Zi Yan Hi all, This patchset tries to remove the restriction on memory hotplug/hotremove granularity, which is always greater or equal to memory section size[1]. With the patchset, kernel is able to online/offl

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread Zi Yan
On 6 May 2021, at 11:31, David Hildenbrand wrote: > On 06.05.21 17:26, Zi Yan wrote: >> From: Zi Yan >> >> Hi all, >> >> This patchset tries to remove the restriction on memory hotplug/hotremove >> granularity, which is always greater or equal to memory section size[1]. >> With the patchset, kern

[RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread Zi Yan
From: Zi Yan Hi all, This patchset tries to remove the restriction on memory hotplug/hotremove granularity, which is always greater or equal to memory section size[1]. With the patchset, kernel is able to online/offline memory at a size independent of memory section size, as small as 2MB (the su

Re: [RFC PATCH 0/7] Memory hotplug/hotremove at subsection size

2021-05-06 Thread David Hildenbrand
On 06.05.21 17:26, Zi Yan wrote: From: Zi Yan Hi all, This patchset tries to remove the restriction on memory hotplug/hotremove granularity, which is always greater or equal to memory section size[1]. With the patchset, kernel is able to online/offline memory at a size independent of memory se