Re: [RFC PATCH 0/2] powerpc: CPU cache op cleanup

2011-11-16 Thread Moffett, Kyle D
On Nov 15, 2011, at 23:40, Paul Mackerras wrote: > On Tue, Nov 15, 2011 at 04:45:18PM -0600, Moffett, Kyle D wrote: >> >> I guess that's doable, although I have to admit that idea almost gives >> me more of a headache than trying to fix up the 32-bit ASM. >> >> One thing that bothers me in partic

Re: [RFC PATCH 0/2] powerpc: CPU cache op cleanup

2011-11-15 Thread Paul Mackerras
On Tue, Nov 15, 2011 at 04:45:18PM -0600, Moffett, Kyle D wrote: > On Nov 15, 2011, at 17:29, Benjamin Herrenschmidt wrote: > > On Mon, 2011-11-14 at 21:32 -0500, Kyle Moffett wrote: > >> Unfortunately, I've been staring at PPC asm for long enough that I > >> have a migraine headache and I'm going

Re: [RFC PATCH 0/2] powerpc: CPU cache op cleanup

2011-11-15 Thread Moffett, Kyle D
On Nov 15, 2011, at 18:46, Benjamin Herrenschmidt wrote: > On Tue, 2011-11-15 at 16:45 -0600, Moffett, Kyle D wrote: >> >> With that said, I'm curious about the origin of the PPC32 ASM. In >> particular, it looks like it was generated by GCC at some point in the >> distant past, and I'm wondering

Re: [RFC PATCH 0/2] powerpc: CPU cache op cleanup

2011-11-15 Thread Benjamin Herrenschmidt
On Tue, 2011-11-15 at 16:45 -0600, Moffett, Kyle D wrote: > I guess that's doable, although I have to admit that idea almost gives > me more of a headache than trying to fix up the 32-bit ASM. > > One thing that bothers me in particular is that both 32/64 versions of > __copy_tofrom_user() are dr

Re: [RFC PATCH 0/2] powerpc: CPU cache op cleanup

2011-11-15 Thread Moffett, Kyle D
On Nov 15, 2011, at 17:29, Benjamin Herrenschmidt wrote: > On Mon, 2011-11-14 at 21:32 -0500, Kyle Moffett wrote: >> Unfortunately, I've been staring at PPC asm for long enough that I >> have a migraine headache and I'm going to have to stop here for now. >> If somebody else wants to tackle fixing

Re: [RFC PATCH 0/2] powerpc: CPU cache op cleanup

2011-11-15 Thread Benjamin Herrenschmidt
On Mon, 2011-11-14 at 21:32 -0500, Kyle Moffett wrote: > Unfortunately, I've been staring at PPC asm for long enough that I > have a migraine headache and I'm going to have to stop here for now. > If somebody else wants to tackle fixing up the 32-bit copy_page() and > __copy_tofrom_user() routines

[RFC PATCH 0/2] powerpc: CPU cache op cleanup

2011-11-14 Thread Kyle Moffett
Ok, so I have a work-in-progress patch for cleaning up the CPU cache handling, and I'd like some comments on the approach. It's not really split up, and it's kind of a huge patch because it tries to tackle a lot of things at once. Unfortunately, I'm having a hard time finding good clean places to