Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-18 Thread Grant Likely
On Fri, Jul 16, 2010 at 5:49 PM, Jamie Lokier wrote: > Daniel Walker wrote: >> > But all the rest is arbitrary and could be part of common shared >> > profiles or the like in defconfig format. >> >> I'm sure most people will want to have a config isolated to their >> specific device. That to me se

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Jamie Lokier
Daniel Walker wrote: > > But all the rest is arbitrary and could be part of common shared > > profiles or the like in defconfig format. > > I'm sure most people will want to have a config isolated to their > specific device. That to me seems reasonable because everyone wants the > smallest possib

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Catalin Marinas
On Fri, 2010-07-16 at 21:17 +0100, Grant Likely wrote: > On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas > wrote: > > On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote: > >> On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: > >> > > >> > DOH. > >> > >> Well, it's possible that the cor

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Grant Likely
On Fri, Jul 16, 2010 at 2:29 PM, Nicolas Pitre wrote: > On Fri, 16 Jul 2010, Grant Likely wrote: > >> On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas >> wrote: >> > On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote: >> >> On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: >> >> > >> >

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Nicolas Pitre
On Fri, 16 Jul 2010, Grant Likely wrote: > On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas > wrote: > > On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote: > >> On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: > >> > > >> > DOH. > >> > >> Well, it's possible that the correct approach

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Grant Likely
On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas wrote: > On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote: >> On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: >> > >> > DOH. >> >> Well, it's possible that the correct approach is a mixture. >> >> Automatically do the trivial cases (r

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Arnd Bergmann
On Friday 16 July 2010 20:46:17 Linus Torvalds wrote: > Maybe a full "solver" is unnecessary, for example, but just a simple > "automatically enable the direct dependencies and scream when it's not > simple any more" would take care of 99% of the common cases, and then > warn when it needs some man

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Catalin Marinas
On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote: > On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: > > > > DOH. > > Well, it's possible that the correct approach is a mixture. > > Automatically do the trivial cases (recursive selects, dependencies > that are simple or of the form

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Arnd Bergmann
On Friday 16 July 2010 19:57:55 Grant Likely wrote: > On Fri, Jul 16, 2010 at 10:03 AM, Catalin Marinas > wrote: > > On Wed, 2010-07-14 at 00:04 +0100, Grant Likely wrote: > > sfr and I were talking about your patch the other day. Just warning > on incomplete dependencies is enough to make it ac

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Grant Likely
On Fri, Jul 16, 2010 at 12:30 PM, Russell King - ARM Linux wrote: > On Fri, Jul 16, 2010 at 02:19:31PM -0400, Nicolas Pitre wrote: >> For example, if I want CONFIG_MTD_CMDLINE_PARTS=y, the system may be >> smart enough to notice and automatically enable CONFIG_MTD and >> CONFIG_MTD_PARTITIONS with

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Linus Torvalds
On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre wrote: > > DOH. Well, it's possible that the correct approach is a mixture. Automatically do the trivial cases (recursive selects, dependencies that are simple or of the form "x && y" etc), and warn about the cases that aren't trivial (where "not t

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Nicolas Pitre
On Fri, 16 Jul 2010, Russell King - ARM Linux wrote: > On Fri, Jul 16, 2010 at 02:19:31PM -0400, Nicolas Pitre wrote: > > For example, if I want CONFIG_MTD_CMDLINE_PARTS=y, the system may be > > smart enough to notice and automatically enable CONFIG_MTD and > > CONFIG_MTD_PARTITIONS without havi

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Nicolas Pitre
On Fri, 16 Jul 2010, Grant Likely wrote: > On Fri, Jul 16, 2010 at 12:19 PM, Nicolas Pitre wrote: > > For example, if I want CONFIG_MTD_CMDLINE_PARTS=y, the system may be > > smart enough to notice and automatically enable CONFIG_MTD and > > CONFIG_MTD_PARTITIONS without having to carry those in t

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Russell King - ARM Linux
On Fri, Jul 16, 2010 at 02:19:31PM -0400, Nicolas Pitre wrote: > For example, if I want CONFIG_MTD_CMDLINE_PARTS=y, the system may be > smart enough to notice and automatically enable CONFIG_MTD and > CONFIG_MTD_PARTITIONS without having to carry those in the defconfig. How do you sort out somet

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Russell King - ARM Linux
On Fri, Jul 16, 2010 at 11:57:55AM -0600, Grant Likely wrote: > Last missing piece is being able to do "select FOO = n", which Stephen > is currently working on. I thought Linus' idea was to use: KBUILD_KCONFIG=file make allnoconfig in which case any option which would be presented to the user w

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Grant Likely
On Fri, Jul 16, 2010 at 12:19 PM, Nicolas Pitre wrote: > On Fri, 16 Jul 2010, Grant Likely wrote: > >> On Fri, Jul 16, 2010 at 10:03 AM, Catalin Marinas >> wrote: >> > On Wed, 2010-07-14 at 00:04 +0100, Grant Likely wrote: >> >> - It still doesn't resolve dependencies.  A solver would help with t

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Nicolas Pitre
On Fri, 16 Jul 2010, Grant Likely wrote: > On Fri, Jul 16, 2010 at 10:03 AM, Catalin Marinas > wrote: > > On Wed, 2010-07-14 at 00:04 +0100, Grant Likely wrote: > >> - It still doesn't resolve dependencies.  A solver would help with this. > >>   For the time being I work around the problem by run

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Grant Likely
On Fri, Jul 16, 2010 at 12:07 PM, Russell King - ARM Linux wrote: > On Fri, Jul 16, 2010 at 11:57:55AM -0600, Grant Likely wrote: >> Last missing piece is being able to do "select FOO = n", which Stephen >> is currently working on. > > I thought Linus' idea was to use: > > KBUILD_KCONFIG=file make

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Linus Torvalds
On Fri, Jul 16, 2010 at 11:07 AM, Russell King - ARM Linux wrote: > > I thought Linus' idea was to use: > > KBUILD_KCONFIG=file make allnoconfig See an earlier reply - that is indeed what I suggested, and yes, it avoids the need to be able to "unselect" things. However, it turns out that even th

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Grant Likely
On Fri, Jul 16, 2010 at 10:03 AM, Catalin Marinas wrote: > On Wed, 2010-07-14 at 00:04 +0100, Grant Likely wrote: >> - It still doesn't resolve dependencies.  A solver would help with this. >>   For the time being I work around the problem by running the generated >>   config through 'oldconfig' a

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Catalin Marinas
On Wed, 2010-07-14 at 00:04 +0100, Grant Likely wrote: > - It still doesn't resolve dependencies. A solver would help with this. > For the time being I work around the problem by running the generated > config through 'oldconfig' and looking for differences. If the files > differ (ignoring

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-14 Thread Daniel Walker
On Tue, 2010-07-13 at 20:07 -0400, Nicolas Pitre wrote: > That's one issue indeed. > > But there is another issue that is somewhat related, which is to be able > to categorize config options. > > Currently the defconfig files carry information about the proper driver > to enable in order to su

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-13 Thread Daniel Walker
On Tue, 2010-07-13 at 17:21 -0600, Grant Likely wrote: > On Tue, Jul 13, 2010 at 5:14 PM, Daniel Walker wrote: > > On Tue, 2010-07-13 at 17:04 -0600, Grant Likely wrote: > > > >> - I haven't figured out a way for the fragment to force an option to > >> be "n", or to set a value, for example "CON

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-13 Thread Daniel Walker
On Tue, 2010-07-13 at 17:04 -0600, Grant Likely wrote: > - I haven't figured out a way for the fragment to force an option to > be "n", or to set a value, for example "CONFIG_LOG_BUF_SHIFT=16". > This may require changing the syntax. > - It still doesn't resolve dependencies. A solver would h

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-13 Thread Nicolas Pitre
On Tue, 13 Jul 2010, Daniel Walker wrote: > On Tue, 2010-07-13 at 17:21 -0600, Grant Likely wrote: > > On Tue, Jul 13, 2010 at 5:14 PM, Daniel Walker > > wrote: > > > It just doesn't feel like Kconfig was meant to do this, it feel like > > > somewhat of an abuse .. > > > > Why? It uses the Kcon

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-13 Thread Grant Likely
On Tue, Jul 13, 2010 at 5:14 PM, Daniel Walker wrote: > On Tue, 2010-07-13 at 17:04 -0600, Grant Likely wrote: > >> - I haven't figured out a way for the fragment to force an option to >>   be "n", or to set a value, for example "CONFIG_LOG_BUF_SHIFT=16". >>   This may require changing the syntax.

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-13 Thread Grant Likely
Typo correction: 2010/7/13 Grant Likely : [...] > .Kconfig defines new board specific config items (prefixed with > "generateconfig_" which default to 'y' or 'm' and select the options > that the platform cares about.  It also then either the architecture s/either the/either includes the/ > defa

[RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-13 Thread Grant Likely
This is a proof of concept at the moment, but if the corner cases can be sorted out, then this might be the best way to replace the defconfig functionality. This patch implements Linus' idea for using Kconfig fragments to replicate the *_defconfig functionality Essentially, this patch adds a new