Re: [RFC 1/3] add support for exporting symbols from .S files

2008-08-12 Thread Arnd Bergmann
This makes it possible to export symbols from assembly files, instead of having to export them through an extra ksyms.c file. Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> --- On Tuesday 12 August 2008, Stephen Rothwell wrote: > This won't be portable across architectures as .align is sometim

Re: [RFC 1/3] add support for exporting symbols from .S files

2008-08-11 Thread Stephen Rothwell
Hi Arnd, On Mon, 11 Aug 2008 16:18:07 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > > +#ifdef CONFIG_MODULES > +.macro __EXPORT_SYMBOL sym section symtab strtab > + .section \section,"a",@progbits > + .type \symtab, @object > + .ifeq BITS_PER_LONG-32 > + .align 3 > +\symtab: > +

Re: [RFC 1/3] add support for exporting symbols from .S files

2008-08-11 Thread Rusty Russell
On Tuesday 12 August 2008 00:18:07 Arnd Bergmann wrote: > This makes it possible to export symbols from assembly files, instead > of having to export them through an extra ksyms.c file. > > I found this nicer to implement using a gas macro than a cpp macro. ... > + .ifeq BITS_PER_LONG-32 > +

Re: [RFC 1/3] add support for exporting symbols from .S files

2008-08-11 Thread David Woodhouse
On Mon, 2008-08-11 at 16:18 +0200, Arnd Bergmann wrote: > This makes it possible to export symbols from assembly files, instead > of having to export them through an extra ksyms.c file. > > I found this nicer to implement using a gas macro than a cpp macro. Yeah, gas macros can be much nicer. Thi

[RFC 1/3] add support for exporting symbols from .S files

2008-08-11 Thread Arnd Bergmann
This makes it possible to export symbols from assembly files, instead of having to export them through an extra ksyms.c file. I found this nicer to implement using a gas macro than a cpp macro. Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> --- a/include/linux/module.h +++ b/include/linux/modu