Re: [RFC 0/2] Consolidate patch_instruction

2017-05-17 Thread LEROY Christophe
Balbir Singh a écrit : On Tue, 2017-05-16 at 22:20 +0200, LEROY Christophe wrote: Balbir Singh a écrit : > patch_instruction is enhanced in this RFC to support > patching via a different virtual address (text_poke_area). > The mapping of text_poke_area->addr is RW and not RWX. > This way the

Re: [RFC 0/2] Consolidate patch_instruction

2017-05-16 Thread Balbir Singh
On Tue, 2017-05-16 at 22:20 +0200, LEROY Christophe wrote: > Balbir Singh a écrit : > > > patch_instruction is enhanced in this RFC to support > > patching via a different virtual address (text_poke_area). > > The mapping of text_poke_area->addr is RW and not RWX. > > This way the mapping allows

Re: [RFC 0/2] Consolidate patch_instruction

2017-05-16 Thread Balbir Singh
On Tue, 2017-05-16 at 19:11 +0530, Naveen N. Rao wrote: > On 2017/05/16 10:56AM, Anshuman Khandual wrote: > > On 05/16/2017 09:19 AM, Balbir Singh wrote: > > > patch_instruction is enhanced in this RFC to support > > > patching via a different virtual address (text_poke_area). > > > > Why writing

Re: [RFC 0/2] Consolidate patch_instruction

2017-05-16 Thread LEROY Christophe
Balbir Singh a écrit : patch_instruction is enhanced in this RFC to support patching via a different virtual address (text_poke_area). The mapping of text_poke_area->addr is RW and not RWX. This way the mapping allows write for patching and then we tear down the mapping. The downside is that we

Re: [RFC 0/2] Consolidate patch_instruction

2017-05-16 Thread Naveen N. Rao
On 2017/05/16 10:56AM, Anshuman Khandual wrote: > On 05/16/2017 09:19 AM, Balbir Singh wrote: > > patch_instruction is enhanced in this RFC to support > > patching via a different virtual address (text_poke_area). > > Why writing instruction directly into the address is not > sufficient and need t

Re: [RFC 0/2] Consolidate patch_instruction

2017-05-15 Thread Anshuman Khandual
On 05/16/2017 09:19 AM, Balbir Singh wrote: > patch_instruction is enhanced in this RFC to support > patching via a different virtual address (text_poke_area). Why writing instruction directly into the address is not sufficient and need to go through this virtual address ? > The mapping of text_p

[RFC 0/2] Consolidate patch_instruction

2017-05-15 Thread Balbir Singh
patch_instruction is enhanced in this RFC to support patching via a different virtual address (text_poke_area). The mapping of text_poke_area->addr is RW and not RWX. This way the mapping allows write for patching and then we tear down the mapping. The downside is that we introduce a spinlock which