Re: [linux-pm] Re: [RFC] powermac: proper sleep management

2007-11-13 Thread Johannes Berg
> Isn't it true that the freezer _already_ isn't enabled on PPC? So > leaving it off wouldn't break anything more than it is broken now. Indeed. johannes signature.asc Description: This is a digitally signed message part ___ Linuxppc-dev mailing li

Re: [linux-pm] Re: [RFC] powermac: proper sleep management

2007-11-12 Thread Alan Stern
On Tue, 13 Nov 2007, Benjamin Herrenschmidt wrote: > I remember fixing various issues so that khubd would be safe when non > frozen (among other things) a while ago. Did you guys break it all > again ? Sorry, I don't know what fixes you're referring to. But come to think of it, some changes I a

Re: [linux-pm] Re: [RFC] powermac: proper sleep management

2007-11-12 Thread Benjamin Herrenschmidt
On Mon, 2007-11-12 at 15:40 -0500, Alan Stern wrote: > On Tue, 13 Nov 2007, Benjamin Herrenschmidt wrote: > > > > > On Mon, 2007-11-12 at 17:32 +0100, Johannes Berg wrote: > > > > Looks good to me, +/- a couple of things: > > > > > > > > - We _REALLY_ want the freezer to be optional and not en

Re: [linux-pm] Re: [RFC] powermac: proper sleep management

2007-11-12 Thread Alan Stern
On Tue, 13 Nov 2007, Benjamin Herrenschmidt wrote: > > On Mon, 2007-11-12 at 17:32 +0100, Johannes Berg wrote: > > > Looks good to me, +/- a couple of things: > > > > > > - We _REALLY_ want the freezer to be optional and not enabled by > > > default on PowerPC. Maybe make it a compile option ?

Re: [RFC] powermac: proper sleep management

2007-11-12 Thread Benjamin Herrenschmidt
On Mon, 2007-11-12 at 17:32 +0100, Johannes Berg wrote: > > Looks good to me, +/- a couple of things: > > > > - We _REALLY_ want the freezer to be optional and not enabled by > > default on PowerPC. Maybe make it a compile option ? > > Well, Alan is going to tell you that USB will break. If we

Re: [linux-pm] Re: [RFC] powermac: proper sleep management

2007-11-12 Thread Alan Stern
On Mon, 12 Nov 2007, Johannes Berg wrote: > > Looks good to me, +/- a couple of things: > > > > - We _REALLY_ want the freezer to be optional and not enabled by > > default on PowerPC. Maybe make it a compile option ? > > Well, Alan is going to tell you that USB will break. If we need > confirm

Re: [RFC] powermac: proper sleep management

2007-11-12 Thread Johannes Berg
> Looks good to me, +/- a couple of things: > > - We _REALLY_ want the freezer to be optional and not enabled by > default on PowerPC. Maybe make it a compile option ? Well, Alan is going to tell you that USB will break. If we need confirmation for that I can do the test he suggested to you or

Re: [RFC] powermac: proper sleep management

2007-11-11 Thread Benjamin Herrenschmidt
> Just thought I'd send out the patch again, it has changed quite a bit > since last time because I cleaned up the code, made it depend on > CONFIG_SUSPEND, made the ioctl backward compatibility optional and some > other bits. > > The feared freezer vs. fuse sync deadlock is no longer present in

Re: [linux-pm] [RFC] powermac: proper sleep management

2007-11-11 Thread Pavel Machek
Hi! > This adds platform_suspend_ops for PMU based machines, directly in > the PMU driver. This finally allows suspending via /sys/power/state > on powerbooks. Thanks for doing this! -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/p

Re: [RFC] powermac: proper sleep management

2007-11-08 Thread Benjamin Herrenschmidt
On Thu, 2007-11-08 at 13:15 -0600, Scott Wood wrote: > Johannes Berg wrote: > > +/* > > + * overrides the weak arch_suspend_disable_irqs in kernel/power/main.c > > + * > > + * XXX: Once Scott Wood's patch is merged, this needs to use the ppc_md > > + * hooks that patch adds! > > + */ > > +void arc

Re: [RFC] powermac: proper sleep management

2007-11-08 Thread Scott Wood
Johannes Berg wrote: > +/* > + * overrides the weak arch_suspend_disable_irqs in kernel/power/main.c > + * > + * XXX: Once Scott Wood's patch is merged, this needs to use the ppc_md > + * hooks that patch adds! > + */ > +void arch_suspend_disable_irqs(void) > +{ > +#ifdef CONFIG_PMAC_BACKLIGHT >

[RFC] powermac: proper sleep management

2007-11-08 Thread Johannes Berg
This adds platform_suspend_ops for PMU based machines, directly in the PMU driver. This finally allows suspending via /sys/power/state on powerbooks. The patch also replaces the PMU ioctl with a simple call to pm_suspend(PM_SUSPEND_MEM) and puts the sleep-related PMU ioctls onto the feature-remova