Re: [RFC] a little disassembly infrastructure

2008-11-03 Thread Paul Mackerras
Hollis Blanchard writes: > Hi, I wrote this patch for KVM [1], but now that I look closer it seems > like there might be some overlapping functionality. Looks OK - Acked-by: Paul Mackerras <[EMAIL PROTECTED]> subject to you writing a suitable patch description. :) Paul. ___

Re: [RFC] a little disassembly infrastructure

2008-11-03 Thread Hollis Blanchard
On Fri, 2008-10-31 at 12:21 -0500, Hollis Blanchard wrote: > On Sat, 2008-10-25 at 13:55 +1100, Paul Mackerras wrote: > > Hollis Blanchard writes: > > > > > I've also found xmon's ppc-opc.c. That parses the opcode and operands, > > > so could use some shared macros. > > > > That's a direct copy f

Re: [RFC] a little disassembly infrastructure

2008-10-31 Thread Hollis Blanchard
On Sat, 2008-10-25 at 13:55 +1100, Paul Mackerras wrote: > Hollis Blanchard writes: > > > I've also found xmon's ppc-opc.c. That parses the opcode and operands, > > so could use some shared macros. > > That's a direct copy from GNU binutils. I'm reluctant to modify it > because then maintenance

Re: [RFC] a little disassembly infrastructure

2008-10-24 Thread Paul Mackerras
Hollis Blanchard writes: > I've also found xmon's ppc-opc.c. That parses the opcode and operands, > so could use some shared macros. That's a direct copy from GNU binutils. I'm reluctant to modify it because then maintenance becomes more than just copying in the latest version. Paul. __

Re: [RFC] a little disassembly infrastructure

2008-10-24 Thread sonny
Hollis Blanchard wrote: Hi, I wrote this patch for KVM [1], but now that I look closer it seems like there might be some overlapping functionality. First there's emulate_instruction(), but since that only handles a few instructions it's just an ordered list of if ((instruction & MASK_A) == INST_

[RFC] a little disassembly infrastructure

2008-10-24 Thread Hollis Blanchard
Hi, I wrote this patch for KVM [1], but now that I look closer it seems like there might be some overlapping functionality. First there's emulate_instruction(), but since that only handles a few instructions it's just an ordered list of if ((instruction & MASK_A) == INST_A) tests, so it doesn't ac