Re: [RFC] Remove memory from nodes for memtrace.

2017-02-26 Thread Oliver O'Halloran
On Thu, Feb 23, 2017 at 8:39 AM, Rashmica Gupta wrote: > Some powerpc hardware features may want to gain access to a > chunk of undisturbed real memory. This update provides a means to unplug > said memory from the kernel with a set of sysfs calls. By writing an integer > containing the siz

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-24 Thread Balbir Singh
On Thu, Feb 23, 2017 at 8:39 AM, Rashmica Gupta wrote: > Some powerpc hardware features may want to gain access to a > chunk of undisturbed real memory. This update provides a means to unplug > said memory from the kernel with a set of sysfs calls. By writing an integer > containing the siz

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread RashmicaGupta
On 23/02/17 14:56, Nicholas Piggin wrote: + +static bool memtrace_offline_pages(u32 nid, u64 start_pfn, u64 nr_pages) +{ + u64 end_pfn = start_pfn + nr_pages - 1; + + if (walk_memory_range(start_pfn, end_pfn, NULL, + check_memblock_online)) + return false;

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread Andrew Donnellan
On 23/02/17 15:23, RashmicaGupta wrote: You'll want to include the Signed-off-by of all authors involved Even without them seeing any changes first? IIUC, you should either run the changes past them first, or add a note (e.g. "[rashmica: general cleanup, refactored foo]") with the changes b

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread RashmicaGupta
On 23/02/17 14:56, Nicholas Piggin wrote: On Thu, 23 Feb 2017 08:39:10 +1100 Rashmica Gupta wrote: Some powerpc hardware features may want to gain access to a chunk of undisturbed real memory. This update provides a means to unplug said memory from the kernel with a set of sysfs calls

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread RashmicaGupta
On 23/02/17 15:01, Andrew Donnellan wrote: On 23/02/17 14:56, Nicholas Piggin wrote: Written by Douglas Lehr . You could mention original author in the changelog. I thought Anton wrote some of it too? You'll want to include the Signed-off-by of all authors involved Even without them seei

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread Andrew Donnellan
On 23/02/17 14:56, Nicholas Piggin wrote: Written by Douglas Lehr . You could mention original author in the changelog. I thought Anton wrote some of it too? You'll want to include the Signed-off-by of all authors involved. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread Nicholas Piggin
On Thu, 23 Feb 2017 08:39:10 +1100 Rashmica Gupta wrote: > Some powerpc hardware features may want to gain access to a > chunk of undisturbed real memory. This update provides a means to unplug > said memory from the kernel with a set of sysfs calls. By writing an integer > containing the

Re: [RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread Stewart Smith
Rashmica Gupta writes: > +} > +machine_device_initcall(powernv, memtrace_init); > + > + > + > +/* XXX FIXME DEBUG CRAP */ > +machine_device_initcall(pseries, memtrace_init); Should the fixme be there? -- Stewart Smith OPAL Architect, IBM.

[RFC] Remove memory from nodes for memtrace.

2017-02-22 Thread Rashmica Gupta
Some powerpc hardware features may want to gain access to a chunk of undisturbed real memory. This update provides a means to unplug said memory from the kernel with a set of sysfs calls. By writing an integer containing the size of memory to be unplugged into /sys/kernel/debug/powerpc/memt