Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Kumar Gala
On Jun 3, 2008, at 12:00 PM, Adrian Bunk wrote: On Tue, Jun 03, 2008 at 09:47:19AM -0500, Kumar Gala wrote: How is this as a fix. - k diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/ platforms/85xx/Kconfig index 7ff29d5..9e5c884 100644 --- a/arch/powerpc/platforms/85xx/Kcon

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Andy Fleming
On Jun 3, 2008, at 12:00, Adrian Bunk wrote: On Tue, Jun 03, 2008 at 09:47:19AM -0500, Kumar Gala wrote: How is this as a fix. - k diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/ platforms/85xx/Kconfig index 7ff29d5..9e5c884 100644 --- a/arch/powerpc/platforms/85xx/Kconfig

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Andy Fleming
On Jun 3, 2008, at 10:31, Kumar Gala wrote: On Jun 3, 2008, at 10:18 AM, Scott Wood wrote: If you just #ifdef PHYLIB, then things will break if the user does this: make config, GIANFAR=PHYLIB=n make zImage make config, GIANFAR=PHYLIB=m make modules And the cause of the failure will not b

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Adrian Bunk
On Tue, Jun 03, 2008 at 09:47:19AM -0500, Kumar Gala wrote: > How is this as a fix. > > - k > > diff --git a/arch/powerpc/platforms/85xx/Kconfig > b/arch/powerpc/platforms/85xx/Kconfig > index 7ff29d5..9e5c884 100644 > --- a/arch/powerpc/platforms/85xx/Kconfig > +++ b/arch/powerpc/platforms/85xx

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Scott Wood
Kumar Gala wrote: I see. However, I don't like the idea I have to build in the PHYLIB if I don't need it at all. Understood, but in practice I don't think the 10K or so matters that much on a typical 85xx board, and if the user really needs to trim things down, they always have the option of m

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Kumar Gala
On Jun 3, 2008, at 10:36 AM, Scott Wood wrote: Kumar Gala wrote: On Jun 3, 2008, at 10:18 AM, Scott Wood wrote: Kumar Gala wrote: On Jun 3, 2008, at 10:10 AM, Scott Wood wrote: I'd rather avoid adding another case where the kernel needs to know what modules are being built, though, especia

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Scott Wood
Kumar Gala wrote: On Jun 3, 2008, at 10:18 AM, Scott Wood wrote: Kumar Gala wrote: On Jun 3, 2008, at 10:10 AM, Scott Wood wrote: I'd rather avoid adding another case where the kernel needs to know what modules are being built, though, especially if the result of changing the .config and buil

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Kumar Gala
On Jun 3, 2008, at 10:18 AM, Scott Wood wrote: Kumar Gala wrote: On Jun 3, 2008, at 10:10 AM, Scott Wood wrote: I'd rather avoid adding another case where the kernel needs to know what modules are being built, though, especially if the result of changing the .config and building modules is

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Scott Wood
Kumar Gala wrote: On Jun 3, 2008, at 10:10 AM, Scott Wood wrote: I'd rather avoid adding another case where the kernel needs to know what modules are being built, though, especially if the result of changing the .config and building modules is a mysterious runtime failure (due to a missing pla

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Kumar Gala
On Jun 3, 2008, at 10:10 AM, Scott Wood wrote: Kumar Gala wrote: How is this as a fix. - k diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/ platforms/85xx/Kconfig index 7ff29d5..9e5c884 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig

Re: [RFC] Make board force selection of PHYLIB

2008-06-03 Thread Scott Wood
Kumar Gala wrote: How is this as a fix. - k diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 7ff29d5..9e5c884 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -34,6 +34,7 @@ config MPC85xx_MDS bool

[RFC] Make board force selection of PHYLIB

2008-06-03 Thread Kumar Gala
How is this as a fix. - k diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 7ff29d5..9e5c884 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -34,6 +34,7 @@ config MPC85xx_MDS bool "Freescale MPC85xx