RE: [RFC] Kprobes for book-e

2008-06-20 Thread Sulibhavi, Madhvesh
Kumar Gala wrote on Thursday, June 19, 2008 10:15 PM > To: Sulibhavi, Madhvesh > > No!!, this code cannot be removed. My tests fail > > while doing the probe test for do_gettimeofday and __kmalloc. > > I get Oops and Segfault. I think i had got similar results > > in my initial port using 2.6.26.39

Re: [RFC] Kprobes for book-e

2008-06-19 Thread Kumar Gala
On Jun 17, 2008, at 8:31 AM, Sulibhavi, Madhvesh wrote: Sulibhavi, Madhvesh wrote on Thursday, June 12, 2008 7:59 PM static void __kprobes prepare_singlestep(struct kprobe *p, struct pt_regs *regs) { +#ifdef CONFIG_BOOKE + regs->msr &= ~(MSR_EE); /* Turn off 'Externel Interrupt' bits */

RE: [RFC] Kprobes for book-e

2008-06-17 Thread Sulibhavi, Madhvesh
Sulibhavi, Madhvesh wrote on Thursday, June 12, 2008 7:59 PM > > > static void __kprobes prepare_singlestep(struct kprobe *p, struct > > > pt_regs *regs) > > > { > > > +#ifdef CONFIG_BOOKE > > > + regs->msr &= ~(MSR_EE); /* Turn off 'Externel Interrupt' bits */ > > > + regs->msr &= ~(MSR_CE); /* Tu

RE: [RFC] Kprobes for book-e

2008-06-12 Thread Sulibhavi, Madhvesh
Kumar Gala wrote Wednesday, June 11, 2008 8:36 PM > To: Sulibhavi, Madhvesh > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linuxppc-dev@ozlabs.org; Paul Mackerras > Subject: Re: [RFC] Kprobes for book-e > ... >

Re: [RFC] Kprobes for book-e

2008-06-11 Thread Kumar Gala
--- Here's a cleaned up version of my patch incorporating the changes we've discussed and some minor tweaks to traps.c. Can you take a look and test it out. I'm wondering about having to clear MSR_EE & MSR_CE in prepare_singlestep(). Doesnt seem like we need to do that at all. - k Documenta

Re: [RFC] Kprobes for book-e

2008-06-11 Thread Kumar Gala
On Jun 11, 2008, at 9:18 AM, Sulibhavi, Madhvesh wrote: Hi Kumar, I could switch to different version of binutils and boot the recent git for ebony target. The kprobes booke patches attached below got applied and i didnot see any issues. These patches can be now pushed to main line? there's

RE: [RFC] Kprobes for book-e

2008-06-11 Thread Sulibhavi, Madhvesh
Hi Kumar, I could switch to different version of binutils and boot the recent git for ebony target. The kprobes booke patches attached below got applied and i didnot see any issues. These patches can be now pushed to main line? Below is the revised patch set after addressing some cleanups in t

RE: [RFC] Kprobes for book-e

2008-06-09 Thread Sulibhavi, Madhvesh
Kumar Gala wrote on Tuesday, June 03, 2008 9:16 PM > To: Sulibhavi, Madhvesh > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linuxppc-dev@ozlabs.org; Paul Mackerras > Subject: Re: [RFC] Kprobes for book-e .. > > > > > I think the block code under CONFIG_BOOKE may

Re: [RFC] Kprobes for book-e

2008-06-03 Thread Kumar Gala
On Jun 3, 2008, at 3:23 AM, Sulibhavi, Madhvesh wrote: Kumar Gala wrote on Tuesday, June 03, 2008 11:01 AM This is a patch that adds kprobes support for book-e style debug. Its based on the patch posted by Madhvesh and assumes the exception cleanup that I've already posted. Thanks for you

RE: [RFC] Kprobes for book-e

2008-06-03 Thread Sulibhavi, Madhvesh
> -Original Message- > From: Josh Boyer [mailto:[EMAIL PROTECTED] > Sent: Tuesday, June 03, 2008 8:17 PM > To: Sulibhavi, Madhvesh > Cc: Kumar Gala; linuxppc-dev@ozlabs.org; [EMAIL PROTECTED]; > Paul Mackerras > Subject: Re: [RFC] Kprobes for book-e > A newer b

Re: [RFC] Kprobes for book-e

2008-06-03 Thread Josh Boyer
linuxppc-dev@ozlabs.org; > > [EMAIL PROTECTED]; Paul Mackerras > > Subject: Re: [RFC] Kprobes for book-e > > > > > This looks like the binutils problem that cell was having and I > > believe Alan Modra fixed: > > > > http://sourceware.org/ml/binu

RE: [RFC] Kprobes for book-e

2008-06-03 Thread Sulibhavi, Madhvesh
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Tuesday, June 03, 2008 8:08 PM > To: Josh Boyer > Cc: Sulibhavi, Madhvesh; linuxppc-dev@ozlabs.org; > [EMAIL PROTECTED]; Paul Mackerras > Subject: Re: [RFC] Kprobes for book-e > > T

Re: [RFC] Kprobes for book-e

2008-06-03 Thread Kumar Gala
On Jun 3, 2008, at 9:18 AM, Josh Boyer wrote: On Tue, 3 Jun 2008 19:40:55 +0530 "Sulibhavi, Madhvesh" <[EMAIL PROTECTED]> wrote: Josh Boyer wrote on Tuesday, June 03, 2008 5:22 PM What build issues? Ebony should build fine for 2.6.26-rc3, unless you're trying to apply this patchset to it wi

RE: [RFC] Kprobes for book-e

2008-06-03 Thread Sulibhavi, Madhvesh
> From: Josh Boyer [mailto:[EMAIL PROTECTED] > Sent: Tuesday, June 03, 2008 7:49 PM > To: Sulibhavi, Madhvesh > Cc: Kumar Gala; linuxppc-dev@ozlabs.org; [EMAIL PROTECTED]; > Paul Mackerras > Subject: Re: [RFC] Kprobes for book-e > > Um, weird. What version of binuti

Re: [RFC] Kprobes for book-e

2008-06-03 Thread Josh Boyer
On Tue, 3 Jun 2008 19:40:55 +0530 "Sulibhavi, Madhvesh" <[EMAIL PROTECTED]> wrote: > Josh Boyer wrote on Tuesday, June 03, 2008 5:22 PM > > What build issues? Ebony should build fine for 2.6.26-rc3, unless > > you're trying to apply this patchset to it without the other > > patches it > > requir

RE: [RFC] Kprobes for book-e

2008-06-03 Thread Sulibhavi, Madhvesh
Josh Boyer wrote on Tuesday, June 03, 2008 5:22 PM > What build issues? Ebony should build fine for 2.6.26-rc3, unless > you're trying to apply this patchset to it without the other > patches it > requires. I am trying without kprobes patches. I get build error as below

Re: [RFC] Kprobes for book-e

2008-06-03 Thread Josh Boyer
On Tue, 3 Jun 2008 13:53:37 +0530 "Sulibhavi, Madhvesh" <[EMAIL PROTECTED]> wrote: > Kumar, i would like to test the updated kprobes patches on my > ebony target using latest kernel. But i am facing build issues using > 2.6.26.rc3 for powerpc arch while using the ebony configuration. > I tried it

RE: [RFC] Kprobes for book-e

2008-06-03 Thread Sulibhavi, Madhvesh
Kumar Gala wrote on Tuesday, June 03, 2008 11:01 AM > This is a patch that adds kprobes support for book-e style debug. Its > based on the patch posted by Madhvesh and assumes the > exception cleanup > that I've already posted. Thanks for your forward port of my previous kprobes patches. Few mon

Re: [RFC] Kprobes for book-e

2008-06-02 Thread Kumar Gala
On Jun 3, 2008, at 12:48 AM, Ananth N Mavinakayanahalli wrote: On Tue, Jun 03, 2008 at 12:30:51AM -0500, Kumar Gala wrote: This is a patch that adds kprobes support for book-e style debug. Its based on the patch posted by Madhvesh and assumes the exception cleanup that I've already posted

Re: [RFC] Kprobes for book-e

2008-06-02 Thread Ananth N Mavinakayanahalli
On Tue, Jun 03, 2008 at 12:30:51AM -0500, Kumar Gala wrote: > This is a patch that adds kprobes support for book-e style debug. Its > based on the patch posted by Madhvesh and assumes the exception cleanup > that I've already posted. > > Post to get any feedback. The code needs some cleaning up

[RFC] Kprobes for book-e

2008-06-02 Thread Kumar Gala
This is a patch that adds kprobes support for book-e style debug. Its based on the patch posted by Madhvesh and assumes the exception cleanup that I've already posted. Post to get any feedback. The code needs some cleaning up but wanted to see if there were any initial comments. - k --- arch/