Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread David Gibson
On Thu, Sep 06, 2007 at 03:36:30PM +0200, Segher Boessenkool wrote: [snip] > >> PCI legacy I/O is not direct mapped: there is no legacy I/O on a > >> PowerPC system bus. So, it can not be mentioned in the "ranges" > >> property, but the PHB registers used to access it should be shown > >> in the "

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread David Gibson
On Thu, Sep 06, 2007 at 03:56:38PM +0200, Segher Boessenkool wrote: > > That looks totally bogus. Unlike Segher, I think there are a few > > cases where overlapping reg and ranges can make sense > > That's not unlike me -- I may have lower tolerance for it though :-) I see. Can't imagine how I

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Gerhard Pircher
Original-Nachricht > Datum: Thu, 6 Sep 2007 15:36:30 +0200 > Von: Segher Boessenkool <[EMAIL PROTECTED]> > An: "Gerhard Pircher" <[EMAIL PROTECTED]> > CC: linuxppc-dev@ozlabs.org, [EMAIL PROTECTED] > Betreff: Re: [RFC] AmigaOne device tree

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
The node should have a compatible property which is sufficient to select the right bridge driver. >>> Yeah, I defined a compatible = "mai,articias"; property in the pci >>> node. >>> Are there any naming conventions (maybe lower case only)? >> >> It's conventional for the part behind the

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Sven Luther
On Thu, Sep 06, 2007 at 04:00:45PM +0200, Segher Boessenkool wrote: > >> The node should have a compatible > >> property which is sufficient to select the right bridge driver. > > Yeah, I defined a compatible = "mai,articias"; property in the pci > > node. > > Are there any naming conventions (may

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
>> The node should have a compatible >> property which is sufficient to select the right bridge driver. > Yeah, I defined a compatible = "mai,articias"; property in the pci > node. > Are there any naming conventions (maybe lower case only)? It's conventional for the part behind the comma to be lo

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
> That looks totally bogus. Unlike Segher, I think there are a few > cases where overlapping reg and ranges can make sense That's not unlike me -- I may have lower tolerance for it though :-) > (PCI bridges > where config space is accessed indirectly via MMIO registers which lie > in the legacy

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
> BTW: It looks like the Pegasos II device tree defines device_type = > "spi" > for the IDE controller. Is that correct? There is no standard binding for an "spi" device type. I have no idea which of various "SPI" kind of devices is meant here; and none of the ones I know of have anything to do

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
>> PCI memory space sits on the PCI bus, not on the PCI host bridge, >> so is not part of "reg" but is part of "ranges" here, since it is >> direct mapped into the host's address space. > That's right, but what about this example here (from a Pegasos II): > > /proc/device-tree/[EMAIL PROTECTED]: >

Re: [RFC] AmigaOne device tree source v2

2007-09-06 Thread Segher Boessenkool
> Hrm.. IIRC, it is permissible under Linux to only include device nodes > for those PCI devices where something must be specified which can't be > proved via PCI. It is. It isn't clear (to me, at least) which properties are required in a PCI node that exists for e.g. interrupt reasons only; or h

Re: [RFC] AmigaOne device tree source v2

2007-09-05 Thread Gerhard Pircher
Original-Nachricht > Datum: Wed, 5 Sep 2007 12:48:05 +1000 > Von: David Gibson <[EMAIL PROTECTED]> > An: Gerhard Pircher <[EMAIL PROTECTED]> > CC: Segher Boessenkool <[EMAIL PROTECTED]>, linuxppc-dev@ozlabs.org > Betreff: Re: [RFC] AmigaOne de

Re: [RFC] AmigaOne device tree source v2

2007-09-04 Thread David Gibson
t; CC: linuxppc-dev@ozlabs.org, David Gibson <[EMAIL PROTECTED]> > > Betreff: Re: [RFC] AmigaOne device tree source v2 > > > PCI memory space sits on the PCI bus, not on the PCI host bridge, > > so is not part of "reg" but is part of "ranges" here, since

Re: [RFC] AmigaOne device tree source v2

2007-09-04 Thread Gerhard Pircher
Original-Nachricht > Datum: Tue, 4 Sep 2007 00:52:02 +0200 > Von: Segher Boessenkool <[EMAIL PROTECTED]> > An: "Gerhard Pircher" <[EMAIL PROTECTED]> > CC: linuxppc-dev@ozlabs.org, David Gibson <[EMAIL PROTECTED]> > Betreff: Re: [RFC]

Re: [RFC] AmigaOne device tree source v2

2007-09-04 Thread Gerhard Pircher
Original-Nachricht > Datum: Tue, 4 Sep 2007 00:32:57 +0200 > Von: Segher Boessenkool <[EMAIL PROTECTED]> > An: "Gerhard Pircher" <[EMAIL PROTECTED]> > CC: linuxppc-dev@ozlabs.org, David Gibson <[EMAIL PROTECTED]> > Betreff: Re: [RFC] A

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread David Gibson
On Tue, Sep 04, 2007 at 12:52:02AM +0200, Segher Boessenkool wrote: > >>> Yeah, PCI is a special case for Linux. Maybe add a "pciclass," > >>> compatible property though, for good measure. Anything else isn't > >>> all that useful I think. > > Wouldn't that be the same as the class-code prope

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread Segher Boessenkool
>>> Yeah, PCI is a special case for Linux. Maybe add a "pciclass," >>> compatible property though, for good measure. Anything else isn't >>> all that useful I think. > Wouldn't that be the same as the class-code property? Sure, except it is a different property. If you use the "class-code"

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread Segher Boessenkool
>>> [EMAIL PROTECTED] { >>> device_type = "pci"; >>> bus-frequency = <01fca055>; // 33.3MHz >>> bus-range = <0 1>; >>> reg = <8000 7f00>; // >>> Whole PCI space. >> >> 'reg' and 'ranges' should not

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread Gerhard Pircher
Hi, Original-Nachricht > Datum: Mon, 3 Sep 2007 20:12:34 +1000 > Von: David Gibson <[EMAIL PROTECTED]> > An: Segher Boessenkool <[EMAIL PROTECTED]> > CC: linuxppc-dev@ozlabs.org > Betreff: Re: [RFC] AmigaOne device tree source v2 > On Mon, Se

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread Gerhard Pircher
Hi, Original-Nachricht > Datum: Mon, 3 Sep 2007 11:34:31 +1000 > Von: David Gibson <[EMAIL PROTECTED]> > An: Gerhard Pircher <[EMAIL PROTECTED]> > CC: linuxppc-dev@ozlabs.org > Betreff: Re: [RFC] AmigaOne device tree source v2 > Interrupt routing i

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread David Gibson
On Mon, Sep 03, 2007 at 12:02:58PM +0200, Segher Boessenkool wrote: > >>> [EMAIL PROTECTED] { > >> > >> The unit address (after the @) should be derived from the first range > >> listed in the 'reg' property. It's a bus address, not a slot number. > > > > Actually... on PCI, the unit add

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread Segher Boessenkool
>>> [EMAIL PROTECTED] { >> >> The unit address (after the @) should be derived from the first range >> listed in the 'reg' property. It's a bus address, not a slot number. > > Actually... on PCI, the unit address is often the slot number, or > rather, "slot,function" with the second pa

Re: [RFC] AmigaOne device tree source v2

2007-09-03 Thread Benjamin Herrenschmidt
> 'reg' and 'ranges' should not typically overlap. 'reg' should only > encode control registers for the bridge, not the whole PCI space (not > that I'm even entirely sure what you mean by that). > > > ranges = <0100 0 fe00 0 00c0 // PCI > > I/O > >

Re: [RFC] AmigaOne device tree source v2

2007-09-02 Thread David Gibson
On Fri, Aug 31, 2007 at 07:50:06PM +0200, Gerhard Pircher wrote: > Hi, > > I updated the AmigaOne device tree based on the comments in this thread: > http://ozlabs.org/pipermail/linuxppc-dev/2007-June/038069.html > All the ISA devices are now subnodes of the PCI2ISA bridge, which marks > the first

[RFC] AmigaOne device tree source v2

2007-08-31 Thread Gerhard Pircher
Hi, I updated the AmigaOne device tree based on the comments in this thread: http://ozlabs.org/pipermail/linuxppc-dev/2007-June/038069.html All the ISA devices are now subnodes of the PCI2ISA bridge, which marks the first 64k (of PCI address space) as I/O space. The pci node doesn't contain any in