Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-13 Thread Nicolin Chen
On Fri, Jun 13, 2014 at 11:00:01AM +0200, Takashi Iwai wrote: > At Thu, 12 Jun 2014 22:24:55 -0500, > Timur Tabi wrote: > > > > On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen > > wrote: > > > > > > +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > > > +

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-13 Thread Takashi Iwai
At Thu, 12 Jun 2014 22:24:55 -0500, Timur Tabi wrote: > > On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen > wrote: > > > > +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > > + int clk_id, unsigned int freq, int dir) > > +{ > > + struct fsl_ssi_

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Nicolin Chen
On Thu, Jun 12, 2014 at 10:44:48PM -0500, Timur Tabi wrote: > On Thu, Jun 12, 2014 at 10:21 PM, Nicolin Chen > wrote: > > > It compiles well with my ARM cross compiler. I guess it might be related > > to the compiler's version? But we should fix it anyway. Would you mind if > > I submit a patch?

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Timur Tabi
On Thu, Jun 12, 2014 at 10:21 PM, Nicolin Chen wrote: > It compiles well with my ARM cross compiler. I guess it might be related > to the compiler's version? But we should fix it anyway. Would you mind if > I submit a patch? Or you do it directly? I just submitted a patch, but I can't test the c

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Nicolin Chen
Sir, On Thu, Jun 12, 2014 at 10:24:55PM -0500, Timur Tabi wrote: > On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen > wrote: > > > > +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > > + int clk_id, unsigned int freq, int dir) > > +{ > > + struct

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Timur Tabi
On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen wrote: > > +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > + int clk_id, unsigned int freq, int dir) > +{ > + struct fsl_ssi_private *ssi_private = > snd_soc_dai_get_drvdata(cpu_dai); > + s

Re: [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2013-12-19 Thread Mark Brown
On Thu, Dec 12, 2013 at 06:44:45PM +0800, Nicolin Chen wrote: > From: Nicolin Chen > > This patch adds three main functions for DAI master mode: set_dai_fmt(), > set_dai_sysclk() and set_dai_tdm_slot(), and one essential baud clock > accordingly. After appending this patch, the fsl_ssi driver on

Re: [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2013-12-18 Thread Nicolin Chen
On Wed, Dec 18, 2013 at 06:59:52PM +, Mark Brown wrote: > On Thu, Dec 12, 2013 at 06:44:45PM +0800, Nicolin Chen wrote: > > > +/** > > + * fsl_ssi_set_dai_tdm_slot - set TDM slot number > > + * > > + * Note: This function can be only called when using SSI as DAI master > > + */ > > +static int

Re: [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2013-12-18 Thread Mark Brown
On Thu, Dec 12, 2013 at 06:44:45PM +0800, Nicolin Chen wrote: > +/** > + * fsl_ssi_set_dai_tdm_slot - set TDM slot number > + * > + * Note: This function can be only called when using SSI as DAI master > + */ > +static int fsl_ssi_set_dai_tdm_slot(struct snd_soc_dai *cpu_dai, u32 tx_mask, > +

[RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2013-12-12 Thread Nicolin Chen
From: Nicolin Chen This patch adds three main functions for DAI master mode: set_dai_fmt(), set_dai_sysclk() and set_dai_tdm_slot(), and one essential baud clock accordingly. After appending this patch, the fsl_ssi driver on i.MX series has the ability to derive LRCLK and BCLK from baud clock sou