Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Peter Zijlstra
On Thu, Jun 08, 2017 at 11:18:13PM +1000, Nicholas Piggin wrote: > I guess I see your point... okay, will constrain the comment to powerpc > context switch and primitives code. Any fundamental change to such > scheduler barriers I guess would require at least a glance over arch > switch code :) Ju

Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Nicholas Piggin
On Thu, 8 Jun 2017 14:45:40 +0200 Peter Zijlstra wrote: > On Thu, Jun 08, 2017 at 08:00:15PM +1000, Nicholas Piggin wrote: > > > I have those, I just also would like one in the core scheduler's use > > of smp_mb__after_spinlock(), because it would be easy for core scheduler > > change to miss th

Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Peter Zijlstra
On Thu, Jun 08, 2017 at 08:00:15PM +1000, Nicholas Piggin wrote: > I have those, I just also would like one in the core scheduler's use > of smp_mb__after_spinlock(), because it would be easy for core scheduler > change to miss that quirk. Sure we can say that Peter and scheduler > maintainers kno

Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Nicholas Piggin
On Thu, 08 Jun 2017 19:54:30 +1000 Michael Ellerman wrote: > Peter Zijlstra writes: > > On Thu, Jun 08, 2017 at 05:29:38PM +1000, Nicholas Piggin wrote: > >> On Thu, 8 Jun 2017 08:54:00 +0200 > >> Peter Zijlstra wrote: > >> > > >> > Right, so this patch relies on the smp_mb__before_spinloc

Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Michael Ellerman
Peter Zijlstra writes: > On Thu, Jun 08, 2017 at 05:29:38PM +1000, Nicholas Piggin wrote: >> On Thu, 8 Jun 2017 08:54:00 +0200 >> Peter Zijlstra wrote: >> > >> > Right, so this patch relies on the smp_mb__before_spinlock -> >> > smp_mb__after_spinlock conversion that makes the rq->lock RCsc and

Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Nicholas Piggin
On Thu, 8 Jun 2017 09:57:20 +0200 Peter Zijlstra wrote: > On Thu, Jun 08, 2017 at 05:29:38PM +1000, Nicholas Piggin wrote: > > On Thu, 8 Jun 2017 08:54:00 +0200 > > Peter Zijlstra wrote: > > > > > On Thu, Jun 08, 2017 at 10:32:44AM +1000, Nicholas Piggin wrote: > > > > On Wed, 07 Jun 2017 1

Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Peter Zijlstra
On Thu, Jun 08, 2017 at 05:29:38PM +1000, Nicholas Piggin wrote: > On Thu, 8 Jun 2017 08:54:00 +0200 > Peter Zijlstra wrote: > > > On Thu, Jun 08, 2017 at 10:32:44AM +1000, Nicholas Piggin wrote: > > > On Wed, 07 Jun 2017 18:15:06 +0200 > > > Peter Zijlstra wrote: > > > > > > > Now that the s

Re: [RFC][PATCH 5/5] powerpc: Remove SYNC from _switch

2017-06-08 Thread Nicholas Piggin
On Thu, 8 Jun 2017 08:54:00 +0200 Peter Zijlstra wrote: > On Thu, Jun 08, 2017 at 10:32:44AM +1000, Nicholas Piggin wrote: > > On Wed, 07 Jun 2017 18:15:06 +0200 > > Peter Zijlstra wrote: > > > > > Now that the scheduler's rq->lock is RCsc and thus provides full > > > transitivity between sch