Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-31 Thread Peter Zijlstra
On Tue, 2012-10-30 at 23:40 -0700, Sukadev Bhattiprolu wrote: > So instead of the names I came up with in this patch, > stalled-cycles-fixed-point > we could use the name used in the CPU spec - 'cmplu_stall_fxu' in the arch > specific code ? You could, but I would advise against it. Human readab

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-30 Thread Sukadev Bhattiprolu
Peter Zijlstra [pet...@infradead.org] wrote: | On Tue, 2012-10-16 at 11:31 -0700, Sukadev Bhattiprolu wrote: | > On a side note, how does the kernel on x86 use the 'config' information in | > say /sys/bus/event_source/devices/cpu/format/cccr ? On Power7, the raw | > code encodes the information su

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-24 Thread Peter Zijlstra
On Tue, 2012-10-16 at 11:31 -0700, Sukadev Bhattiprolu wrote: > On a side note, how does the kernel on x86 use the 'config' information in > say /sys/bus/event_source/devices/cpu/format/cccr ? On Power7, the raw > code encodes the information such as the PMC to use for the event. Is that > how the

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-19 Thread Sukadev Bhattiprolu
Stephane Eranian [eran...@google.com] wrote: | So all in all, I think this is not a very good idea. You have to put | this into the tool or a library that auto-detects the | host CPU and programs the right set of events. | | We've had that discussion many times. Just reiterating my personal | opin

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-16 Thread Sukadev Bhattiprolu
Robert Richter [robert.rich...@amd.com] wrote: | Sukadev, | | On 15.10.12 17:55:34, Robert Richter wrote: | > On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: | > > + { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, | > > + { .type = PERF_TYPE_HARDWARE, .confi

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-16 Thread Stephane Eranian
On Tue, Oct 16, 2012 at 12:08 PM, Robert Richter wrote: > Sukadev, > > On 15.10.12 17:55:34, Robert Richter wrote: >> On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: >> > + { .type = PERF_TYPE_HARDWARE, .config = >> > PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, >> > + { .type = PERF_TYPE_HARDW

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-16 Thread Robert Richter
Sukadev, On 15.10.12 17:55:34, Robert Richter wrote: > On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: > > + { .type = PERF_TYPE_HARDWARE, .config = > > PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, > > + { .type = PERF_TYPE_HARDWARE, .config = > > PERF_COUNT_HW_STALLED_CYCLES_LOAD_STORE }, > >

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-15 Thread Anshuman Khandual
On 10/15/2012 10:53 PM, Arun Sharma wrote: > On 10/15/12 8:55 AM, Robert Richter wrote: > > [..] >> Perf tool works then out-of-the-box with: >> >> $ perf record -e cpu/stalled-cycles-fixed-point/ ... >> >> The event string can easily be reused by other architectures as a >> quasi standard. > >

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-15 Thread Arun Sharma
On 10/15/12 8:55 AM, Robert Richter wrote: [..] Perf tool works then out-of-the-box with: $ perf record -e cpu/stalled-cycles-fixed-point/ ... The event string can easily be reused by other architectures as a quasi standard. I like Robert's proposal better. It's hard to model all the stall

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-15 Thread Robert Richter
On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: > + { .type = PERF_TYPE_HARDWARE, .config = > PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, > + { .type = PERF_TYPE_HARDWARE, .config = > PERF_COUNT_HW_STALLED_CYCLES_LOAD_STORE }, > + { .type = PERF_TYPE_HARDWARE, .config = > PERF_COUNT_HW_STALL

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-14 Thread Anshuman Khandual
On 10/12/2012 06:58 AM, Sukadev Bhattiprolu wrote: > > From 89cb6a25b9f714e55a379467a832ee015014ed11 Mon Sep 17 00:00:00 2001 > From: Sukadev Bhattiprolu > Date: Tue, 18 Sep 2012 10:59:01 -0700 > Subject: [PATCH] perf: Add a few generic stalled-cycles events > > The existing generic event 'stall

[RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-11 Thread Sukadev Bhattiprolu
>From 89cb6a25b9f714e55a379467a832ee015014ed11 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Tue, 18 Sep 2012 10:59:01 -0700 Subject: [PATCH] perf: Add a few generic stalled-cycles events The existing generic event 'stalled-cycles-backend' corresponds to PM_CMPLU_STALL event in Power7