Re: [RFC/PATCHv3] powerpc: Move CPM command handling into the cpm drivers

2007-11-26 Thread Jochen Friedrich
Hi Scott, >> +spin_lock_irqsave(&cmd_lock, flags); > > I'm a little uneasy about this -- what's the longest it can take for the > CPM command to complete (or timeout)? I'd rather use a mutex, if we can > make sure that it's never called from atomic context. Unfortunately, fs_enet may call t

Re: [RFC/PATCHv3] powerpc: Move CPM command handling into the cpm drivers

2007-11-26 Thread Scott Wood
Jochen Friedrich wrote: > diff --git a/arch/powerpc/sysdev/commproc.c > b/arch/powerpc/sysdev/commproc.c > index f6a6378..2426bcb 100644 > --- a/arch/powerpc/sysdev/commproc.c > +++ b/arch/powerpc/sysdev/commproc.c > @@ -240,6 +240,34 @@ void __init cpm_reset(void) > #endif > } > > +static DEFINE

[RFC/PATCHv3] powerpc: Move CPM command handling into the cpm drivers

2007-11-24 Thread Jochen Friedrich
This patch moves the CPM command handling into commproc.c for CPM1 and cpm2_common.c. This is yet another preparation to get rid of drivers accessing the CPM via the global cpmp. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/commproc.c | 28 +++