Re: [RFC/PATCH] Fix rtas_ibm_suspend_me bugs

2007-11-07 Thread Nathan Lynch
Nathan Lynch wrote: > (very rfc for now, no sign-off, needs more testing) > > There are a couple of bugs in the rtas_ibm_suspend_me() and > rtas_percpu_suspend_me() functions: > > 1. rtas_ibm_suspend_me() uses on_each_cpu() to invoke > rtas_percpu_suspend_me() via IPI: > > if (on_each_cpu(rtas_

Re: [RFC/PATCH] Fix rtas_ibm_suspend_me bugs

2007-11-06 Thread jschopp
> -for_each_possible_cpu(i) > -plpar_hcall_norets(H_PROD,i); ... > +for_each_online_cpu(i) > +plpar_hcall_norets(H_PROD, get_hard_smp_processor_id(i)); I assume this bit would be non-contriversial and could be sent up for immediate upstream in

[RFC/PATCH] Fix rtas_ibm_suspend_me bugs

2007-11-05 Thread Nathan Lynch
(very rfc for now, no sign-off, needs more testing) There are a couple of bugs in the rtas_ibm_suspend_me() and rtas_percpu_suspend_me() functions: 1. rtas_ibm_suspend_me() uses on_each_cpu() to invoke rtas_percpu_suspend_me() via IPI: if (on_each_cpu(rtas_percpu_suspend_me, &data, 1, 0)) ...