Re: [RFC,PATCH 3/7 v2] arm/versatile: use generic struct clk

2010-01-24 Thread Jeremy Kerr
Hi Russell, > This doesn't make any sense. What are you trying to do here? > > The get/put operations go together as one logical set - that's why you > get both if you're using clkdev, and why you're asked to implement both > __clk_get() and __clk_put() in arch code to do whatever's necessary >

Re: [RFC,PATCH 3/7 v2] arm/versatile: use generic struct clk

2010-01-12 Thread Russell King - ARM Linux
On Tue, Jan 12, 2010 at 05:58:31PM +1100, Jeremy Kerr wrote: > diff --git a/arch/arm/common/clkdev.c b/arch/arm/common/clkdev.c > index aae5bc0..71e7596 100644 > --- a/arch/arm/common/clkdev.c > +++ b/arch/arm/common/clkdev.c > @@ -85,11 +85,13 @@ struct clk *clk_get(struct device *dev, const char

[RFC,PATCH 3/7 v2] arm/versatile: use generic struct clk

2010-01-11 Thread Jeremy Kerr
Use the common struct clk interface for the versatile clocks. Signed-off-by: Jeremy Kerr --- arch/arm/Kconfig|1 arch/arm/common/clkdev.c|2 + arch/arm/mach-versatile/clock.c | 51 +--- arch/arm/mach-versatile/clock.h | 20 +++