Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-30 Thread Benjamin Herrenschmidt
On Tue, 2012-05-01 at 07:55 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-04-30 at 13:41 -0400, David Miller wrote: > > From: Benjamin Herrenschmidt > > Date: Mon, 30 Apr 2012 15:26:08 +1000 > > > > > David, what's the right way to fix that ? > > > > There is no doubt that sock_fprog is th

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-30 Thread Benjamin Herrenschmidt
On Mon, 2012-04-30 at 13:41 -0400, David Miller wrote: > From: Benjamin Herrenschmidt > Date: Mon, 30 Apr 2012 15:26:08 +1000 > > > David, what's the right way to fix that ? > > There is no doubt that sock_fprog is the correct datastructure to use. Ok, so the right fix is to email anybody who p

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-30 Thread David Miller
From: Benjamin Herrenschmidt Date: Mon, 30 Apr 2012 15:26:08 +1000 > David, what's the right way to fix that ? There is no doubt that sock_fprog is the correct datastructure to use. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://li

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Benjamin Herrenschmidt
> No idea, i was going by the old saying: > "Thou shall not include kernel header, or you will feel the wrath of angry > kernel gurus." Heh :-) Well, googling around, it looks like there's a mix of both type of programs out there. Those using a struct bpf_program and those using a struct soft_fp

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Jan Seiffert
Benjamin Herrenschmidt schrieb: > On Mon, 2012-04-30 at 06:27 +0200, Jan Seiffert wrote: >> Benjamin Herrenschmidt schrieb: >>> On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote: >>> > Matt's having a look at powerpc Ok, he hasn't so I'll dig a bit. No obvious

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Benjamin Herrenschmidt
On Mon, 2012-04-30 at 06:27 +0200, Jan Seiffert wrote: > Benjamin Herrenschmidt schrieb: > > On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote: > > > >>> Matt's having a look at powerpc > >> > >> Ok, he hasn't so I'll dig a bit. > >> > >> No obvious wrongness (but I'm not very famili

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Jan Seiffert
Benjamin Herrenschmidt schrieb: > On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote: > >>> Matt's having a look at powerpc >> >> Ok, he hasn't so I'll dig a bit. >> >> No obvious wrongness (but I'm not very familiar with bpf), though I do >> have a comment: sk_negative_common() and b

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Benjamin Herrenschmidt
On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote: > > Matt's having a look at powerpc > > Ok, he hasn't so I'll dig a bit. > > No obvious wrongness (but I'm not very familiar with bpf), though I do > have a comment: sk_negative_common() and bpf_slow_path_common() should > be made

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Jan Seiffert
Benjamin Herrenschmidt schrieb: > On Wed, 2012-04-04 at 08:11 +1000, Benjamin Herrenschmidt wrote: >> On Tue, 2012-04-03 at 18:03 -0400, David Miller wrote: >> Signed-off-by: Jan Seiffert I have only compile tested this, -ENOHARDWARE. Can someone with more powerpc kung-fu rev

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Benjamin Herrenschmidt
On Mon, 2012-04-30 at 12:43 +1000, Benjamin Herrenschmidt wrote: > Ok, he hasn't so I'll dig a bit. > > No obvious wrongness (but I'm not very familiar with bpf), though I do > have a comment: sk_negative_common() and bpf_slow_path_common() should > be made one and single macro which takes the fa

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-29 Thread Benjamin Herrenschmidt
On Wed, 2012-04-04 at 08:11 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2012-04-03 at 18:03 -0400, David Miller wrote: > > > > Signed-off-by: Jan Seiffert > > > > > > I have only compile tested this, -ENOHARDWARE. > > > Can someone with more powerpc kung-fu review and maybe test this? > > > E

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-03 Thread Benjamin Herrenschmidt
On Tue, 2012-04-03 at 18:03 -0400, David Miller wrote: > > Signed-off-by: Jan Seiffert > > > > I have only compile tested this, -ENOHARDWARE. > > Can someone with more powerpc kung-fu review and maybe test this? > > Esp. powerpc asm is not my strong point. I think i botched the > > stack frame i

Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-04-03 Thread David Miller
From: Jan Seiffert Date: Fri, 30 Mar 2012 17:35:01 +0200 > Now the helper function from filter.c for negative offsets is exported, > it can be used it in the jit to handle negative offsets. > > First modify the asm load helper functions to handle: > - know positive offsets > - know negative offs

[REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle negative offsets

2012-03-30 Thread Jan Seiffert
Now the helper function from filter.c for negative offsets is exported, it can be used it in the jit to handle negative offsets. First modify the asm load helper functions to handle: - know positive offsets - know negative offsets - any offset then the compiler can be modified to explicitly use t