Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-08-04 Thread David Gibson
On Tue, Aug 04, 2009 at 02:29:38AM +0530, K.Prasad wrote: > On Fri, Jul 31, 2009 at 04:16:46PM +1000, David Gibson wrote: > > On Mon, Jul 27, 2009 at 05:43:17AM +0530, K.Prasad wrote: [snip] > > > + /* Verify if dar lies within the address range occupied by the symbol > > > + * being watched. Sinc

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-08-03 Thread K.Prasad
On Fri, Jul 31, 2009 at 04:16:46PM +1000, David Gibson wrote: > On Mon, Jul 27, 2009 at 05:43:17AM +0530, K.Prasad wrote: > > Introduce PPC64 implementation for the generic hardware breakpoint > > interfaces > > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and > > the > >

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-07-30 Thread David Gibson
On Mon, Jul 27, 2009 at 05:43:17AM +0530, K.Prasad wrote: > Introduce PPC64 implementation for the generic hardware breakpoint interfaces > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the > Makefile. [snip] > +/* > + * Handle debug exception notifications. > + */ > +i

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-07-26 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile|2 arch/powerpc

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-07-03 Thread K.Prasad
On Fri, Jun 19, 2009 at 03:04:09PM +1000, David Gibson wrote: > On Thu, Jun 18, 2009 at 11:50:45PM +0530, K.Prasad wrote: > > On Wed, Jun 17, 2009 at 02:32:24PM +1000, David Gibson wrote: > > > On Wed, Jun 10, 2009 at 02:38:06PM +0530, K.Prasad wrote: > [snip] With apologies for the long delay her

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-18 Thread David Gibson
On Thu, Jun 18, 2009 at 11:50:45PM +0530, K.Prasad wrote: > On Wed, Jun 17, 2009 at 02:32:24PM +1000, David Gibson wrote: > > On Wed, Jun 10, 2009 at 02:38:06PM +0530, K.Prasad wrote: [snip] > > > +int arch_validate_hwbkpt_settings(struct hw_breakpoint *bp, > > > +

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-18 Thread K.Prasad
On Wed, Jun 17, 2009 at 02:32:24PM +1000, David Gibson wrote: > On Wed, Jun 10, 2009 at 02:38:06PM +0530, K.Prasad wrote: > > Introduce PPC64 implementation for the generic hardware breakpoint > > interfaces > > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and > > the > >

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-16 Thread David Gibson
On Mon, Jun 15, 2009 at 12:48:28PM +0530, K.Prasad wrote: > On Mon, Jun 15, 2009 at 04:40:45PM +1000, David Gibson wrote: > > On Wed, Jun 10, 2009 at 12:13:49PM +0530, K.Prasad wrote: > > > On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: > > > > On Wed, Jun 03, 2009 at 10:05:11PM +053

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-16 Thread David Gibson
On Wed, Jun 10, 2009 at 02:38:06PM +0530, K.Prasad wrote: > Introduce PPC64 implementation for the generic hardware breakpoint interfaces > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the > Makefile. [snip] > +void arch_update_kernel_hw_breakpoint(void *unused) > +{ >

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-15 Thread K.Prasad
On Mon, Jun 15, 2009 at 04:40:45PM +1000, David Gibson wrote: > On Wed, Jun 10, 2009 at 12:13:49PM +0530, K.Prasad wrote: > > On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: > > > On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: > > > > > > + else { > > > > +

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-14 Thread David Gibson
On Wed, Jun 10, 2009 at 12:13:49PM +0530, K.Prasad wrote: > On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: > > On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: > > Hi David, > Sorry for the delay in response below. In the meanwhile, I > discovered an issue in detectin

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-10 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile|2 arch/powerpc

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-09 Thread K.Prasad
On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: > On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: Hi David, Sorry for the delay in response below. In the meanwhile, I discovered an issue in detecting stray exceptions that affected user-space handling of breakpoints.

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-04 Thread David Gibson
On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: > Introduce PPC64 implementation for the generic hardware breakpoint interfaces > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the > Makefile. [snip] > +/* > + * Install the debug register values for just the k

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-03 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile|2 arch/powerpc

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-29 Thread K.Prasad
On Fri, May 29, 2009 at 02:18:49PM +1000, David Gibson wrote: > On Mon, May 25, 2009 at 06:45:22AM +0530, K.Prasad wrote: > > +/* > > + * Handle debug exception notifications. > > + */ > > +int __kprobes hw_breakpoint_handler(struct die_args *args) > > +{ > > + int rc = NOTIFY_STOP; > > + struc

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-28 Thread David Gibson
On Mon, May 25, 2009 at 06:45:22AM +0530, K.Prasad wrote: > Introduce PPC64 implementation for the generic hardware breakpoint interfaces > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the > Makefile. [snip] > +/* Store the kernel-space breakpoint address value */ > +s

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-24 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile|2 arch/powerpc

[RFC Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-21 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile|2 arch/powerpc

Re: [RFC Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-14 Thread Michael Ellerman
On Thu, 2009-05-14 at 19:14 +0530, K.Prasad wrote: > plain text document attachment (ppc64_arch_hwbkpt_implementation_02) > Introduce PPC64 implementation for the generic hardware breakpoint interfaces > defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the > Makefile. Hi,

[RFC Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-14 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile|2 arch/powerpc