Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-03-25 Thread Stephen Rothwell
Hi Jochen, Firstly, you should probably cc Dave Miller <[EMAIL PROTECTED]> on anything in drivers/of as Sparc is the other user of this stuff (just in case they are interested). On Tue, 25 Mar 2008 19:46:41 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > > +++ b/drivers/of/i2c.c > @@ -0,0 +1,

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-03-25 Thread Jochen Friedrich
Hi Jean, >> What is the preferred way to do this? > > I still have to think about it. I didn't have much time to work on this > during the last 2 weeks, hopefully I will fine some time to experiment > again soon. As I underlined before, my patch set affects no less than 5 > subsystems with differ

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-25 Thread Jochen Friedrich
Hi Olof, > And even if you DO decide to go that route, guess what? You need a > translation table just as with (3) anyway! True. 3. use a glue layer with a translation map. >>> In my opinion this is an OK solution since the same information has to >>> be added somewhere already anyway -- ei

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-24 Thread Olof Johansson
Hi, On Sun, Feb 24, 2008 at 04:16:30PM +0100, Jochen Friedrich wrote: > Hi Olof, > > >> 2. record the I2c name in the dts tree, either as seperate tag (like > >> linux,i2c-name="") > >>or as additional compatible entry (like compatible="...", > >> "linux,"). > > > > I have to say no on thi

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-24 Thread Jon Smirl
On 2/22/08, Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Hi Jean, > > > >> +/* > >> + * Wait for patch from Jon Smirl > >> + * #include "powerpc-common.h" > >> + */ > > > > It doesn't make sense to merge this comment upstream. > > > I know you don't like the patch from Jon Smirl and you also

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-24 Thread Jochen Friedrich
Hi Olof, >> 2. record the I2c name in the dts tree, either as seperate tag (like >> linux,i2c-name="") >>or as additional compatible entry (like compatible="...", >> "linux,"). > > I have to say no on this one. The device tree is not supposed to know > about how linux uses devices, there ar

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-23 Thread Olof Johansson
On Fri, Feb 22, 2008 at 12:16:16PM +0100, Jochen Friedrich wrote: > Fortunately, I2c no longer uses numeric device IDs but names. So what are the > alternatives? > > 1. modify the I2c subsystem to accept OF names additionally to I2c names > (proposed by Jon smirl). Sounds like Jean isn't very

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-23 Thread Jean Delvare
Hi Jochen, On Fri, 22 Feb 2008 12:16:16 +0100, Jochen Friedrich wrote: > Hi Jean, > > >> +/* > >> + * Wait for patch from Jon Smirl > >> + * #include "powerpc-common.h" > >> + */ > > > > It doesn't make sense to merge this comment upstream. > > I know you don't like the patch from Jon Smirl and

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-22 Thread Jochen Friedrich
Hi Jean, >> +/* >> + * Wait for patch from Jon Smirl >> + * #include "powerpc-common.h" >> + */ > > It doesn't make sense to merge this comment upstream. I know you don't like the patch from Jon Smirl and you also explained your reasons. Fortunately, I2c no longer uses numeric device IDs but na

Re: [PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-02-21 Thread Jean Delvare
Hallo Jochen, On Thu, 31 Jan 2008 13:54:01 +0100, Jochen Friedrich wrote: > Using the port of 2.4 code from Vitaly Bordug <[EMAIL PROTECTED]> > and the actual algorithm used by the i2c driver of the DBox code on > cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and > i2c-

[PATCHv4 2.6.25] i2c: adds support for i2c bus on Freescale CPM1/CPM2 controllers

2008-01-31 Thread Jochen Friedrich
Using the port of 2.4 code from Vitaly Bordug <[EMAIL PROTECTED]> and the actual algorithm used by the i2c driver of the DBox code on cvs.tuxboc.org from Tmbinc, Gillem ([EMAIL PROTECTED]). Renamed i2c-rpx.c and i2c-algo-8xx.c to i2c-cpm.c and converted the driver to an of_platform_driver. Signed-