Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-07 Thread Mark Brown
On Thu, Nov 07, 2013 at 03:01:02AM +, Li Xiubo wrote: > > > The SGTL5000 is based on regulators and when it is disabled, there > > > will be an error returns directly while the SGTL5000 codec is probing. > > What makes you say this? > static int ldo_regulator_register(struct snd_soc_codec *

RE: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-06 Thread Li Xiubo
> > The SGTL5000 is based on regulators and when it is disabled, there > > will be an error returns directly while the SGTL5000 codec is probing. > > What makes you say this? > >From the code: File path: "sound/soc/codecs/sgtl5000.c" == #ifdef CONFIG_REGULATOR . #else static

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-06 Thread Mark Brown
On Wed, Nov 06, 2013 at 08:59:53AM +, Li Xiubo wrote: Please fix your mailer to word wrap within paragraphs. > The SGTL5000 is based on regulators and when it is disabled, there > will be an error returns directly while the SGTL5000 codec is probing. What makes you say this? That's not how

RE: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-06 Thread Li Xiubo
> > On VF610 series there are no regulators used, and now whether the > > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio patch > > series, the board cannot be probe successfully. > > And this patch will solve this issue. > > I don't understand what this is for at all, you're just sa

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-01 Thread Mark Brown
On Fri, Nov 01, 2013 at 03:04:52PM +0800, Xiubo Li wrote: > On VF610 series there are no regulators used, and now whether the > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio > patch series, the board cannot be probe successfully. > And this patch will solve this issue. I don't unde

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-01 Thread Nicolin Chen
On Fri, Nov 01, 2013 at 03:04:52PM +0800, Xiubo Li wrote: > On VF610 series there are no regulators used, and now whether the > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio micro? or macro? > patch series, the board cannot be probe successfully. > And this patch will solve this i

[PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-01 Thread Xiubo Li
On VF610 series there are no regulators used, and now whether the CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio patch series, the board cannot be probe successfully. And this patch will solve this issue. Signed-off-by: Xiubo Li --- sound/soc/codecs/sgtl5000.c | 12 1